Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: gpu/command_buffer/client/gles2_implementation.cc

Issue 788123002: Add sampler related ES3 APIs to command buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/client/gles2_implementation.cc
diff --git a/gpu/command_buffer/client/gles2_implementation.cc b/gpu/command_buffer/client/gles2_implementation.cc
index 19a005f43015f6ecf1b55f43ed478262133acacc..3243cd950eb6a488f987a2c11d73883ac25e61af 100644
--- a/gpu/command_buffer/client/gles2_implementation.cc
+++ b/gpu/command_buffer/client/gles2_implementation.cc
@@ -2314,6 +2314,10 @@ void GLES2Implementation::GenValuebuffersCHROMIUMHelper(
const GLuint* /* valuebuffers */) {
}
+void GLES2Implementation::GenSamplersHelper(
+ GLsizei /* n */, const GLuint* /* samplers */) {
bajones 2014/12/10 23:13:58 Just double checking: Is this intended to be an em
Zhenyao Mo 2014/12/10 23:41:15 Yes, it's only added for the purpose of VertexArra
+}
+
// NOTE #1: On old versions of OpenGL, calling glBindXXX with an unused id
// generates a new resource. On newer versions of OpenGL they don't. The code
// related to binding below will need to change if we switch to the new OpenGL
@@ -2684,6 +2688,22 @@ void GLES2Implementation::DeleteValuebuffersCHROMIUMHelper(
}
}
+void GLES2Implementation::DeleteSamplersStub(
+ GLsizei n, const GLuint* samplers) {
+ helper_->DeleteSamplersImmediate(n, samplers);
+}
+
+void GLES2Implementation::DeleteSamplersHelper(
+ GLsizei n, const GLuint* samplers) {
+ if (!GetIdHandler(id_namespaces::kSamplers)->FreeIds(
+ this, n, samplers, &GLES2Implementation::DeleteSamplersStub)) {
+ SetGLError(
+ GL_INVALID_VALUE,
+ "glDeleteSamplers", "id not created by this context.");
+ return;
+ }
+}
+
void GLES2Implementation::DeleteValuebuffersCHROMIUMStub(
GLsizei n,
const GLuint* valuebuffers) {
@@ -3985,6 +4005,18 @@ bool GLES2Implementation::ValidateOffset(const char* func, GLintptr offset) {
return true;
}
+bool GLES2Implementation::GetSamplerParameterfvHelper(
+ GLuint /* sampler */, GLenum /* pname */, GLfloat* /* params */) {
+ // TODO(zmo): Implement client side caching.
+ return false;
+}
+
+bool GLES2Implementation::GetSamplerParameterivHelper(
+ GLuint /* sampler */, GLenum /* pname */, GLint* /* params */) {
+ // TODO(zmo): Implement client side caching.
+ return false;
+}
+
// Include the auto-generated part of this file. We split this because it means
// we can easily edit the non-auto generated parts right here in this file
// instead of having to edit some template or the code generator.

Powered by Google App Engine
This is Rietveld 408576698