Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 617853003: Revert of Add isSingleComponent bool to getConstantColorComponent (Closed)

Created:
6 years, 2 months ago by robertphillips
Modified:
6 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Add isSingleComponent bool to getConstantColorComponent (patchset #6 id:100001 of https://codereview.chromium.org/608253002/) Reason for revert: Changing some GMs Original issue's description: > Add isSingleComponent bool to getConstantColorComponent > > Initial step to allowing effects to use/output 1 or 4 color/coverage components. This cl doesn't change any current logic and all effects still assume they are working with 4 components. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/3b8af078281a5a20f951b9fd84f38d92b8f6217b TBR=joshualitt@chromium.org,bsalomon@google.com,reed@google.com,egdaniel@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/b4b7a4c9ea2e399db550f93e3754c351e5b2079a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+346 lines, -455 lines) Patch
M include/gpu/GrProcessor.h View 2 chunks +7 lines, -46 lines 0 comments Download
M src/core/SkXfermode.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M src/effects/SkArithmeticMode.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 5 chunks +9 lines, -10 lines 0 comments Download
M src/effects/SkColorFilters.cpp View 3 chunks +8 lines, -9 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 2 chunks +45 lines, -45 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M src/effects/SkLumaColorFilter.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 3 chunks +3 lines, -5 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 2 chunks +9 lines, -10 lines 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +6 lines, -7 lines 0 comments Download
M src/effects/gradients/SkGradientShaderPriv.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 2 chunks +33 lines, -32 lines 0 comments Download
M src/gpu/GrOptDrawState.cpp View 2 chunks +11 lines, -12 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 6 chunks +15 lines, -15 lines 0 comments Download
M src/gpu/GrPaint.cpp View 2 chunks +10 lines, -14 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 1 chunk +0 lines, -42 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.h View 4 chunks +15 lines, -15 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConvexPolyEffect.cpp View 3 chunks +13 lines, -14 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.h View 2 chunks +6 lines, -7 lines 0 comments Download
M src/gpu/effects/GrCustomCoordsTextureEffect.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrCustomCoordsTextureEffect.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 4 chunks +8 lines, -10 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.h View 4 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 2 chunks +14 lines, -14 lines 0 comments Download
M src/gpu/effects/GrDitherEffect.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.h View 2 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/effects/GrOvalEffect.cpp View 4 chunks +8 lines, -10 lines 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 4 chunks +8 lines, -10 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/effects/GrSingleTextureEffect.h View 1 chunk +6 lines, -5 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 chunk +4 lines, -5 lines 0 comments Download
M src/gpu/effects/GrYUVtoRGBEffect.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
M tests/GpuColorFilterTest.cpp View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robertphillips
Created Revert of Add isSingleComponent bool to getConstantColorComponent
6 years, 2 months ago (2014-10-02 19:11:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617853003/1
6 years, 2 months ago (2014-10-02 19:11:31 UTC) #2
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 19:12:54 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as b4b7a4c9ea2e399db550f93e3754c351e5b2079a

Powered by Google App Engine
This is Rietveld 408576698