Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: src/gpu/effects/GrConvolutionEffect.h

Issue 617853003: Revert of Add isSingleComponent bool to getConstantColorComponent (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/gpu/effects/GrConvexPolyEffect.cpp ('k') | src/gpu/effects/GrCustomCoordsTextureEffect.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 Google Inc. 2 * Copyright 2012 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #ifndef GrConvolutionEffect_DEFINED 8 #ifndef GrConvolutionEffect_DEFINED
9 #define GrConvolutionEffect_DEFINED 9 #define GrConvolutionEffect_DEFINED
10 10
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 57
58 const float* bounds() const { return fBounds; } 58 const float* bounds() const { return fBounds; }
59 bool useBounds() const { return fUseBounds; } 59 bool useBounds() const { return fUseBounds; }
60 60
61 static const char* Name() { return "Convolution"; } 61 static const char* Name() { return "Convolution"; }
62 62
63 typedef GrGLConvolutionEffect GLProcessor; 63 typedef GrGLConvolutionEffect GLProcessor;
64 64
65 virtual const GrBackendFragmentProcessorFactory& getFactory() const SK_OVERR IDE; 65 virtual const GrBackendFragmentProcessorFactory& getFactory() const SK_OVERR IDE;
66 66
67 virtual void getConstantColorComponents(GrColor*, uint32_t* validFlags) cons t {
68 // If the texture was opaque we could know that the output color if we k new the sum of the
69 // kernel values.
70 *validFlags = 0;
71 }
72
67 enum { 73 enum {
68 // This was decided based on the min allowed value for the max texture 74 // This was decided based on the min allowed value for the max texture
69 // samples per fragment program run in DX9SM2 (32). A sigma param of 4.0 75 // samples per fragment program run in DX9SM2 (32). A sigma param of 4.0
70 // on a blur filter gives a kernel width of 25 while a sigma of 5.0 76 // on a blur filter gives a kernel width of 25 while a sigma of 5.0
71 // would exceed a 32 wide kernel. 77 // would exceed a 32 wide kernel.
72 kMaxKernelRadius = 12, 78 kMaxKernelRadius = 12,
73 // With a C++11 we could have a constexpr version of WidthFromRadius() 79 // With a C++11 we could have a constexpr version of WidthFromRadius()
74 // and not have to duplicate this calculation. 80 // and not have to duplicate this calculation.
75 kMaxKernelWidth = 2 * kMaxKernelRadius + 1, 81 kMaxKernelWidth = 2 * kMaxKernelRadius + 1,
76 }; 82 };
(...skipping 13 matching lines...) Expand all
90 96
91 /// Convolve with a Gaussian kernel 97 /// Convolve with a Gaussian kernel
92 GrConvolutionEffect(GrTexture*, Direction, 98 GrConvolutionEffect(GrTexture*, Direction,
93 int halfWidth, 99 int halfWidth,
94 float gaussianSigma, 100 float gaussianSigma,
95 bool useBounds, 101 bool useBounds,
96 float bounds[2]); 102 float bounds[2]);
97 103
98 virtual bool onIsEqual(const GrProcessor&) const SK_OVERRIDE; 104 virtual bool onIsEqual(const GrProcessor&) const SK_OVERRIDE;
99 105
100 virtual void onComputeInvariantOutput(InvariantOutput* inout) const {
101 // If the texture was opaque we could know that the output color if we k new the sum of the
102 // kernel values.
103 inout->fValidFlags = 0;
104 inout->fIsSingleComponent = false;
105 }
106
107 GR_DECLARE_FRAGMENT_PROCESSOR_TEST; 106 GR_DECLARE_FRAGMENT_PROCESSOR_TEST;
108 107
109 typedef Gr1DKernelEffect INHERITED; 108 typedef Gr1DKernelEffect INHERITED;
110 }; 109 };
111 110
112 #endif 111 #endif
OLDNEW
« no previous file with comments | « src/gpu/effects/GrConvexPolyEffect.cpp ('k') | src/gpu/effects/GrCustomCoordsTextureEffect.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698