Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher. (Closed)

Created:
6 years, 3 months ago by Yoyo Zhou
Modified:
6 years, 3 months ago
Reviewers:
Lei Zhang, James Cook
CC:
chromium-reviews, vandebo (ex-Chrome), nkostylev+watch_chromium.org, tburkard+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, dmazzoni+watch_chromium.org, stevenjb+watch_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, aboxhall+watch_chromium.org, chromium-apps-reviews_chromium.org, Greg Billock, yuzo+watch_chromium.org, gavinp+prer_chromium.org, oshima+watch_chromium.org, davidben+watch_chromium.org, plundblad+watch_chromium.org, Lei Zhang, tommycli, dominich+watch_chromium.org, dtseng+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Project:
chromium
Visibility:
Public.

Description

Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher. BUG=388893 Committed: https://crrev.com/e8dc2f1ff837e32b9d02d65ab520d16187450bf9 Cr-Commit-Position: refs/heads/master@{#294031}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -236 lines) Patch
M chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/apps/app_browsertest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/apps/app_pointer_lock_interactive_uitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/apps/app_window_browsertest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/apps/app_window_interactive_uitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/apps/ephemeral_app_browsertest.cc View 3 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/accessibility_features_apitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/active_tab_apitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/context_menus/context_menu_apitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/dial/dial_apitest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/browser_action_apitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/extension_action/page_action_apitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/gcm/gcm_apitest.cc View 5 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/i18n/i18n_apitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/mdns/mdns_apitest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/notifications/notifications_apitest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/preference/preference_apitest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/proxy/proxy_apitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_apitest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/push_messaging/push_messaging_canary_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/socket/socket_apitest.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/sockets_tcp/sockets_tcp_apitest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/sockets_udp/sockets_udp_apitest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/storage/settings_apitest.cc View 6 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_apitest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/system_indicator/system_indicator_apitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/system_storage/system_storage_apitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_apitest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/content_script_apitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_apitest.h View 1 chunk +1 line, -41 lines 0 comments Download
M chrome/browser/extensions/extension_apitest.cc View 3 chunks +2 lines, -71 lines 0 comments Download
M chrome/browser/extensions/extension_bindings_apitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_commands_global_registry_apitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_incognito_apitest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_keybinding_apitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_override_apitest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/lazy_background_page_apitest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/stubs_apitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/window_open_apitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/guest_view/extension_options/extension_options_apitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/pdf/pdf_extension_test.cc View 2 chunks +2 lines, -1 line 0 comments Download
M extensions/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_apitest.cc View 9 chunks +9 lines, -7 lines 0 comments Download
M extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc View 27 chunks +27 lines, -28 lines 0 comments Download
M extensions/browser/api/bluetooth_socket/bluetooth_socket_apitest.cc View 5 chunks +5 lines, -3 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_channel_apitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M extensions/browser/api/runtime/runtime_apitest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M extensions/browser/api/serial/serial_apitest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M extensions/test/result_catcher.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
Yoyo Zhou
James, please have a look. This is an entirely mechanical change.
6 years, 3 months ago (2014-09-09 00:29:13 UTC) #2
James Cook
LGTM!
6 years, 3 months ago (2014-09-09 15:38:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/555633003/1
6 years, 3 months ago (2014-09-09 20:14:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/9751) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/11779) win_chromium_rel_swarming ...
6 years, 3 months ago (2014-09-09 21:23:50 UTC) #7
Lei Zhang
There's a few failing API tests. Are those flakes?
6 years, 3 months ago (2014-09-09 21:27:27 UTC) #9
Lei Zhang
non-extensions portion of chrome/ lgtm
6 years, 3 months ago (2014-09-09 21:29:29 UTC) #10
Yoyo Zhou
On 2014/09/09 21:29:29, Lei Zhang wrote: > non-extensions portion of chrome/ lgtm Thanks. This doesn't ...
6 years, 3 months ago (2014-09-09 21:56:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/555633003/1
6 years, 3 months ago (2014-09-09 22:06:22 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as 949ffd8c906295021fd1dc6b1bdb2738cbd6a815
6 years, 3 months ago (2014-09-09 23:17:54 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:56:24 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8dc2f1ff837e32b9d02d65ab520d16187450bf9
Cr-Commit-Position: refs/heads/master@{#294031}

Powered by Google App Engine
This is Rietveld 408576698