chrome/browser/extensions/api/preference/preference_apitest.cc - Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/preference/preference_apitest.cc

Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc ('k') | chrome/browser/extensions/api/proxy/proxy_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/preference/preference_apitest.cc

diff --git a/chrome/browser/extensions/api/preference/preference_apitest.cc b/chrome/browser/extensions/api/preference/preference_apitest.cc

index 71b8afd7d88709e915f1c19fd8d9b53cb2d0ed70..e90539aa5855d3d0b066807cd21cc4dd927f2fe5 100644

--- a/chrome/browser/extensions/api/preference/preference_apitest.cc

+++ b/chrome/browser/extensions/api/preference/preference_apitest.cc

@@ -17,6 +17,7 @@

#include "content/public/browser/notification_service.h"

#include "extensions/browser/extension_registry.h"

#include "extensions/browser/test_extension_registry_observer.h"

+#include "extensions/test/result_catcher.h"

namespace {

@@ -206,10 +207,11 @@ IN_PROC_BROWSER_TEST_F(ExtensionPreferenceApiTest, OnChange) {

}

IN_PROC_BROWSER_TEST_F(ExtensionPreferenceApiTest, OnChangeSplit) {

- ResultCatcher catcher;

- catcher.RestrictToProfile(profile_);

- ResultCatcher catcher_incognito;

- catcher_incognito.RestrictToProfile(profile_->GetOffTheRecordProfile());

+ extensions::ResultCatcher catcher;

+ catcher.RestrictToBrowserContext(profile_);

+ extensions::ResultCatcher catcher_incognito;

+ catcher_incognito.RestrictToBrowserContext(

+ profile_->GetOffTheRecordProfile());

// Open an incognito window.

ui_test_utils::OpenURLOffTheRecord(profile_, GURL("chrome://newtab/"));