Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher.

chrome/browser/extensions/extension_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_apitest.h"
 
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/unpacked_installer.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/extensions/application_launch.h"
 #include "chrome/test/base/ui_test_utils.h"
-#include "content/public/browser/notification_registrar.h"
-#include "content/public/browser/notification_service.h"
 #include "extensions/browser/api/test/test_api.h"
 #include "extensions/browser/extension_system.h"
-#include "extensions/browser/notification_types.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_set.h"
+#include "extensions/test/result_catcher.h"
 #include "net/base/escape.h"
 #include "net/base/filename_util.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 #include "net/test/embedded_test_server/http_request.h"
 #include "net/test/embedded_test_server/http_response.h"
 #include "net/test/spawned_test_server/spawned_test_server.h"
 
 namespace {
 
 const char kTestCustomArg[] = "customArg";
@@ skipping 101 matching lines @@
   embedded_test_server()->RegisterRequestHandler(
       base::Bind(&HandleEchoHeaderRequest));
   embedded_test_server()->RegisterRequestHandler(
       base::Bind(&HandleSetCookieRequest));
   embedded_test_server()->RegisterRequestHandler(
       base::Bind(&HandleSetHeaderRequest));
 }
 
 ExtensionApiTest::~ExtensionApiTest() {}
 
-ExtensionApiTest::ResultCatcher::ResultCatcher()
-    : profile_restriction_(NULL),
-      waiting_(false) {
-  registrar_.Add(this,
-                 extensions::NOTIFICATION_EXTENSION_TEST_PASSED,
-                 content::NotificationService::AllSources());
-  registrar_.Add(this,
-                 extensions::NOTIFICATION_EXTENSION_TEST_FAILED,
-                 content::NotificationService::AllSources());
-}
-
-ExtensionApiTest::ResultCatcher::~ResultCatcher() {
-}
-
-bool ExtensionApiTest::ResultCatcher::GetNextResult() {
-  // Depending on the tests, multiple results can come in from a single call
-  // to RunMessageLoop(), so we maintain a queue of results and just pull them
-  // off as the test calls this, going to the run loop only when the queue is
-  // empty.
-  if (results_.empty()) {
-    waiting_ = true;
-    content::RunMessageLoop();
-    waiting_ = false;
-  }
-
-  if (!results_.empty()) {
-    bool ret = results_.front();
-    results_.pop_front();
-    message_ = messages_.front();
-    messages_.pop_front();
-    return ret;
-  }
-
-  NOTREACHED();
-  return false;
-}
-
-void ExtensionApiTest::ResultCatcher::Observe(
-    int type, const content::NotificationSource& source,
-    const content::NotificationDetails& details) {
-  if (profile_restriction_ &&
-      content::Source<Profile>(source).ptr() != profile_restriction_) {
-    return;
-  }
-
-  switch (type) {
-    case extensions::NOTIFICATION_EXTENSION_TEST_PASSED:
-      VLOG(1) << "Got EXTENSION_TEST_PASSED notification.";
-      results_.push_back(true);
-      messages_.push_back(std::string());
-      if (waiting_)
-        base::MessageLoopForUI::current()->Quit();
-      break;
-
-    case extensions::NOTIFICATION_EXTENSION_TEST_FAILED:
-      VLOG(1) << "Got EXTENSION_TEST_FAILED notification.";
-      results_.push_back(false);
-      messages_.push_back(*(content::Details<std::string>(details).ptr()));
-      if (waiting_)
-        base::MessageLoopForUI::current()->Quit();
-      break;
-
-    default:
-      NOTREACHED();
-  }
-}
-
 void ExtensionApiTest::SetUpInProcessBrowserTestFixture() {
   DCHECK(!test_config_.get()) << "Previous test did not clear config state.";
   test_config_.reset(new base::DictionaryValue());
   test_config_->SetString(kTestDataDirectory,
                           net::FilePathToFileURL(test_data_dir_).spec());
   test_config_->SetInteger(kTestWebSocketPort, 0);
   extensions::TestGetConfigFunction::set_test_config_state(
       test_config_.get());
 }
 
@@ skipping 100 matching lines @@
                                             const std::string& page_url,
                                             const char* custom_arg,
                                             int flags) {
   bool load_as_component = (flags & kFlagLoadAsComponent) != 0;
   bool launch_platform_app = (flags & kFlagLaunchPlatformApp) != 0;
   bool use_incognito = (flags & kFlagUseIncognito) != 0;
 
   if (custom_arg && custom_arg[0])
     test_config_->SetString(kTestCustomArg, custom_arg);
 
-  ResultCatcher catcher;
+  extensions::ResultCatcher catcher;
   DCHECK(!extension_name.empty() || !page_url.empty()) <<
       "extension_name and page_url cannot both be empty";
 
   const extensions::Extension* extension = NULL;
   if (!extension_name.empty()) {
     base::FilePath extension_path = test_data_dir_.AppendASCII(extension_name);
     if (load_as_component) {
       extension = LoadExtensionAsComponent(extension_path);
     } else {
       int browser_test_flags = ExtensionBrowserTest::kFlagNone;
@@ skipping 136 matching lines @@
   test_config_->SetInteger(kSpawnedTestServerPort,
                            test_server()->host_port_pair().port());
 
   return true;
 }
 
 void ExtensionApiTest::SetUpCommandLine(CommandLine* command_line) {
   ExtensionBrowserTest::SetUpCommandLine(command_line);
   test_data_dir_ = test_data_dir_.AppendASCII("api_test");
 }