Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Side by Side Diff: chrome/browser/extensions/api/socket/socket_apitest.cc

Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/ref_counted.h" 5 #include "base/memory/ref_counted.h"
6 #include "base/strings/stringprintf.h" 6 #include "base/strings/stringprintf.h"
7 #include "chrome/browser/extensions/extension_apitest.h" 7 #include "chrome/browser/extensions/extension_apitest.h"
8 #include "chrome/browser/extensions/extension_service.h" 8 #include "chrome/browser/extensions/extension_service.h"
9 #include "chrome/browser/extensions/extension_test_message_listener.h" 9 #include "chrome/browser/extensions/extension_test_message_listener.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
11 #include "chrome/common/chrome_paths.h" 11 #include "chrome/common/chrome_paths.h"
12 #include "chrome/test/base/in_process_browser_test.h" 12 #include "chrome/test/base/in_process_browser_test.h"
13 #include "chrome/test/base/ui_test_utils.h" 13 #include "chrome/test/base/ui_test_utils.h"
14 #include "extensions/browser/api/dns/host_resolver_wrapper.h" 14 #include "extensions/browser/api/dns/host_resolver_wrapper.h"
15 #include "extensions/browser/api/dns/mock_host_resolver_creator.h" 15 #include "extensions/browser/api/dns/mock_host_resolver_creator.h"
16 #include "extensions/browser/api/socket/socket_api.h" 16 #include "extensions/browser/api/socket/socket_api.h"
17 #include "extensions/test/result_catcher.h"
17 #include "net/dns/mock_host_resolver.h" 18 #include "net/dns/mock_host_resolver.h"
18 #include "net/test/spawned_test_server/spawned_test_server.h" 19 #include "net/test/spawned_test_server/spawned_test_server.h"
19 20
20 using extensions::Extension; 21 using extensions::Extension;
22 using extensions::ResultCatcher;
21 23
22 namespace { 24 namespace {
23 25
24 const std::string kHostname = "127.0.0.1"; 26 const std::string kHostname = "127.0.0.1";
25 const int kPort = 8888; 27 const int kPort = 8888;
26 28
27 class SocketApiTest : public ExtensionApiTest { 29 class SocketApiTest : public ExtensionApiTest {
28 public: 30 public:
29 SocketApiTest() : resolver_event_(true, false), 31 SocketApiTest() : resolver_event_(true, false),
30 resolver_creator_( 32 resolver_creator_(
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 EXPECT_TRUE(test_server->Start()); 64 EXPECT_TRUE(test_server->Start());
63 65
64 net::HostPortPair host_port_pair = test_server->host_port_pair(); 66 net::HostPortPair host_port_pair = test_server->host_port_pair();
65 int port = host_port_pair.port(); 67 int port = host_port_pair.port();
66 ASSERT_GT(port, 0); 68 ASSERT_GT(port, 0);
67 69
68 // Test that sendTo() is properly resolving hostnames. 70 // Test that sendTo() is properly resolving hostnames.
69 host_port_pair.set_host("LOCALhost"); 71 host_port_pair.set_host("LOCALhost");
70 72
71 ResultCatcher catcher; 73 ResultCatcher catcher;
72 catcher.RestrictToProfile(browser()->profile()); 74 catcher.RestrictToBrowserContext(browser()->profile());
73 75
74 ExtensionTestMessageListener listener("info_please", true); 76 ExtensionTestMessageListener listener("info_please", true);
75 77
76 ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("socket/api"))); 78 ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("socket/api")));
77 EXPECT_TRUE(listener.WaitUntilSatisfied()); 79 EXPECT_TRUE(listener.WaitUntilSatisfied());
78 listener.Reply( 80 listener.Reply(
79 base::StringPrintf("udp:%s:%d", host_port_pair.host().c_str(), port)); 81 base::StringPrintf("udp:%s:%d", host_port_pair.host().c_str(), port));
80 82
81 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message(); 83 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
82 } 84 }
83 85
84 IN_PROC_BROWSER_TEST_F(SocketApiTest, SocketTCPExtension) { 86 IN_PROC_BROWSER_TEST_F(SocketApiTest, SocketTCPExtension) {
85 scoped_ptr<net::SpawnedTestServer> test_server( 87 scoped_ptr<net::SpawnedTestServer> test_server(
86 new net::SpawnedTestServer( 88 new net::SpawnedTestServer(
87 net::SpawnedTestServer::TYPE_TCP_ECHO, 89 net::SpawnedTestServer::TYPE_TCP_ECHO,
88 net::SpawnedTestServer::kLocalhost, 90 net::SpawnedTestServer::kLocalhost,
89 base::FilePath(FILE_PATH_LITERAL("net/data")))); 91 base::FilePath(FILE_PATH_LITERAL("net/data"))));
90 EXPECT_TRUE(test_server->Start()); 92 EXPECT_TRUE(test_server->Start());
91 93
92 net::HostPortPair host_port_pair = test_server->host_port_pair(); 94 net::HostPortPair host_port_pair = test_server->host_port_pair();
93 int port = host_port_pair.port(); 95 int port = host_port_pair.port();
94 ASSERT_GT(port, 0); 96 ASSERT_GT(port, 0);
95 97
96 // Test that connect() is properly resolving hostnames. 98 // Test that connect() is properly resolving hostnames.
97 host_port_pair.set_host("lOcAlHoSt"); 99 host_port_pair.set_host("lOcAlHoSt");
98 100
99 ResultCatcher catcher; 101 ResultCatcher catcher;
100 catcher.RestrictToProfile(browser()->profile()); 102 catcher.RestrictToBrowserContext(browser()->profile());
101 103
102 ExtensionTestMessageListener listener("info_please", true); 104 ExtensionTestMessageListener listener("info_please", true);
103 105
104 ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("socket/api"))); 106 ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("socket/api")));
105 EXPECT_TRUE(listener.WaitUntilSatisfied()); 107 EXPECT_TRUE(listener.WaitUntilSatisfied());
106 listener.Reply( 108 listener.Reply(
107 base::StringPrintf("tcp:%s:%d", host_port_pair.host().c_str(), port)); 109 base::StringPrintf("tcp:%s:%d", host_port_pair.host().c_str(), port));
108 110
109 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message(); 111 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
110 } 112 }
111 113
112 IN_PROC_BROWSER_TEST_F(SocketApiTest, SocketTCPServerExtension) { 114 IN_PROC_BROWSER_TEST_F(SocketApiTest, SocketTCPServerExtension) {
113 ResultCatcher catcher; 115 ResultCatcher catcher;
114 catcher.RestrictToProfile(browser()->profile()); 116 catcher.RestrictToBrowserContext(browser()->profile());
115 ExtensionTestMessageListener listener("info_please", true); 117 ExtensionTestMessageListener listener("info_please", true);
116 ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("socket/api"))); 118 ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("socket/api")));
117 EXPECT_TRUE(listener.WaitUntilSatisfied()); 119 EXPECT_TRUE(listener.WaitUntilSatisfied());
118 listener.Reply( 120 listener.Reply(
119 base::StringPrintf("tcp_server:%s:%d", kHostname.c_str(), kPort)); 121 base::StringPrintf("tcp_server:%s:%d", kHostname.c_str(), kPort));
120 122
121 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message(); 123 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
122 } 124 }
123 125
124 IN_PROC_BROWSER_TEST_F(SocketApiTest, SocketTCPServerUnbindOnUnload) { 126 IN_PROC_BROWSER_TEST_F(SocketApiTest, SocketTCPServerUnbindOnUnload) {
125 ResultCatcher catcher; 127 ResultCatcher catcher;
126 const Extension* extension = 128 const Extension* extension =
127 LoadExtension(test_data_dir_.AppendASCII("socket/unload")); 129 LoadExtension(test_data_dir_.AppendASCII("socket/unload"));
128 ASSERT_TRUE(extension); 130 ASSERT_TRUE(extension);
129 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message(); 131 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
130 132
131 UnloadExtension(extension->id()); 133 UnloadExtension(extension->id());
132 134
133 ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("socket/unload"))) 135 ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("socket/unload")))
134 << message_; 136 << message_;
135 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message(); 137 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
136 } 138 }
137 139
138 IN_PROC_BROWSER_TEST_F(SocketApiTest, SocketMulticast) { 140 IN_PROC_BROWSER_TEST_F(SocketApiTest, SocketMulticast) {
139 ResultCatcher catcher; 141 ResultCatcher catcher;
140 catcher.RestrictToProfile(browser()->profile()); 142 catcher.RestrictToBrowserContext(browser()->profile());
141 ExtensionTestMessageListener listener("info_please", true); 143 ExtensionTestMessageListener listener("info_please", true);
142 ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("socket/api"))); 144 ASSERT_TRUE(LoadExtension(test_data_dir_.AppendASCII("socket/api")));
143 EXPECT_TRUE(listener.WaitUntilSatisfied()); 145 EXPECT_TRUE(listener.WaitUntilSatisfied());
144 listener.Reply( 146 listener.Reply(
145 base::StringPrintf("multicast:%s:%d", kHostname.c_str(), kPort)); 147 base::StringPrintf("multicast:%s:%d", kHostname.c_str(), kPort));
146 148
147 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message(); 149 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
148 } 150 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698