Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Side by Side Diff: chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/memory/ref_counted.h" 5 #include "base/memory/ref_counted.h"
6 #include "base/path_service.h" 6 #include "base/path_service.h"
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "chrome/browser/extensions/extension_apitest.h" 8 #include "chrome/browser/extensions/extension_apitest.h"
9 #include "chrome/browser/extensions/extension_function_test_utils.h" 9 #include "chrome/browser/extensions/extension_function_test_utils.h"
10 #include "chrome/browser/extensions/extension_service.h" 10 #include "chrome/browser/extensions/extension_service.h"
11 #include "chrome/browser/extensions/extension_test_message_listener.h" 11 #include "chrome/browser/extensions/extension_test_message_listener.h"
12 #include "chrome/browser/ui/browser.h" 12 #include "chrome/browser/ui/browser.h"
13 #include "chrome/browser/ui/extensions/application_launch.h" 13 #include "chrome/browser/ui/extensions/application_launch.h"
14 #include "chrome/common/chrome_paths.h" 14 #include "chrome/common/chrome_paths.h"
15 #include "chrome/test/base/in_process_browser_test.h" 15 #include "chrome/test/base/in_process_browser_test.h"
16 #include "chrome/test/base/ui_test_utils.h" 16 #include "chrome/test/base/ui_test_utils.h"
17 #include "extensions/browser/api/dns/host_resolver_wrapper.h" 17 #include "extensions/browser/api/dns/host_resolver_wrapper.h"
18 #include "extensions/browser/api/dns/mock_host_resolver_creator.h" 18 #include "extensions/browser/api/dns/mock_host_resolver_creator.h"
19 #include "extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h" 19 #include "extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h"
20 #include "extensions/test/result_catcher.h"
20 #include "net/dns/mock_host_resolver.h" 21 #include "net/dns/mock_host_resolver.h"
21 #include "net/test/spawned_test_server/spawned_test_server.h" 22 #include "net/test/spawned_test_server/spawned_test_server.h"
22 23
23 using extensions::Extension; 24 using extensions::Extension;
24 using extensions::core_api::SocketsTcpServerCreateFunction; 25 using extensions::core_api::SocketsTcpServerCreateFunction;
25 26
26 namespace utils = extension_function_test_utils; 27 namespace utils = extension_function_test_utils;
27 28
28 namespace { 29 namespace {
29 30
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 ASSERT_EQ(base::Value::TYPE_DICTIONARY, result->GetType()); 80 ASSERT_EQ(base::Value::TYPE_DICTIONARY, result->GetType());
80 base::DictionaryValue *value = 81 base::DictionaryValue *value =
81 static_cast<base::DictionaryValue*>(result.get()); 82 static_cast<base::DictionaryValue*>(result.get());
82 int socketId = -1; 83 int socketId = -1;
83 EXPECT_TRUE(value->GetInteger("socketId", &socketId)); 84 EXPECT_TRUE(value->GetInteger("socketId", &socketId));
84 ASSERT_TRUE(socketId > 0); 85 ASSERT_TRUE(socketId > 0);
85 } 86 }
86 87
87 IN_PROC_BROWSER_TEST_F(SocketsTcpServerApiTest, SocketTCPServerExtension) { 88 IN_PROC_BROWSER_TEST_F(SocketsTcpServerApiTest, SocketTCPServerExtension) {
88 base::FilePath path = test_data_dir_.AppendASCII("sockets_tcp_server/api"); 89 base::FilePath path = test_data_dir_.AppendASCII("sockets_tcp_server/api");
89 ResultCatcher catcher; 90 extensions::ResultCatcher catcher;
90 catcher.RestrictToProfile(browser()->profile()); 91 catcher.RestrictToBrowserContext(browser()->profile());
91 ExtensionTestMessageListener listener("info_please", true); 92 ExtensionTestMessageListener listener("info_please", true);
92 ASSERT_TRUE(LoadExtension(path)); 93 ASSERT_TRUE(LoadExtension(path));
93 EXPECT_TRUE(listener.WaitUntilSatisfied()); 94 EXPECT_TRUE(listener.WaitUntilSatisfied());
94 listener.Reply( 95 listener.Reply(
95 base::StringPrintf("tcp_server:%s:%d", kHostname.c_str(), kPort)); 96 base::StringPrintf("tcp_server:%s:%d", kHostname.c_str(), kPort));
96 97
97 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message(); 98 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
98 } 99 }
99 100
100 IN_PROC_BROWSER_TEST_F(SocketsTcpServerApiTest, SocketTCPServerUnbindOnUnload) { 101 IN_PROC_BROWSER_TEST_F(SocketsTcpServerApiTest, SocketTCPServerUnbindOnUnload) {
101 base::FilePath path = test_data_dir_.AppendASCII("sockets_tcp_server/unload"); 102 base::FilePath path = test_data_dir_.AppendASCII("sockets_tcp_server/unload");
102 ResultCatcher catcher; 103 extensions::ResultCatcher catcher;
103 const Extension* extension = LoadExtension(path); 104 const Extension* extension = LoadExtension(path);
104 ASSERT_TRUE(extension); 105 ASSERT_TRUE(extension);
105 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message(); 106 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
106 107
107 UnloadExtension(extension->id()); 108 UnloadExtension(extension->id());
108 109
109 ASSERT_TRUE(LoadExtension(path)) << message_; 110 ASSERT_TRUE(LoadExtension(path)) << message_;
110 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message(); 111 EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();
111 } 112 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698