chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc - Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc

Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc ('k') | chrome/browser/extensions/api/preference/preference_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc

diff --git a/chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc b/chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc

index f0c0e9d6b331927d8783b8f9b0c6d811f1f6959b..c686d9062d801348381c8e454c3a00ee63a977a1 100644

--- a/chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc

+++ b/chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc

@@ -7,7 +7,7 @@

#include "chrome/browser/search_engines/template_url_service_factory.h"

#include "chrome/test/base/ui_test_utils.h"

#include "components/metrics/proto/omnibox_event.pb.h"

+#include "extensions/test/result_catcher.h"

// Tests that the autocomplete popup doesn't reopen after accepting input for

// a given query.

@@ -38,7 +38,7 @@ IN_PROC_BROWSER_TEST_F(OmniboxApiTest, PopupStaysClosed) {

// Quickly type another query and accept it before getting suggestions back

// for the query. The popup will close after accepting input - ensure that it

// does not reopen when the extension returns its suggestions.

- ResultCatcher catcher;

+ extensions::ResultCatcher catcher;

// TODO: Rather than send this second request by talking to the controller

// directly, figure out how to send it via the proper calls to