chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc - Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc

Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/notifications/notifications_apitest.cc ('k') | chrome/browser/extensions/api/omnibox/omnibox_api_interactive_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc

diff --git a/chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc b/chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc

index 190eb589a8cc5e4f8ba0eb00172c90b6d542e890..63edfe685894dda86568745dd60dd9b4ebd208d1 100644

--- a/chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc

+++ b/chrome/browser/extensions/api/omnibox/omnibox_api_browsertest.cc

@@ -17,9 +17,11 @@

#include "components/omnibox/autocomplete_input.h"

#include "components/omnibox/autocomplete_match.h"

#include "components/omnibox/autocomplete_result.h"

+#include "extensions/test/result_catcher.h"

#include "ui/base/window_open_disposition.h"

using base::ASCIIToUTF16;

+using extensions::ResultCatcher;

using metrics::OmniboxEventProto;

// http://crbug.com/167158

@@ -203,7 +205,7 @@ IN_PROC_BROWSER_TEST_F(OmniboxApiTest, OnInputEntered) {

IN_PROC_BROWSER_TEST_F(OmniboxApiTest, DISABLED_IncognitoSplitMode) {

Profile* profile = browser()->profile();

ResultCatcher catcher_incognito;

- catcher_incognito.RestrictToProfile(profile->GetOffTheRecordProfile());

+ catcher_incognito.RestrictToBrowserContext(profile->GetOffTheRecordProfile());

ASSERT_TRUE(RunExtensionTestIncognito("omnibox")) << message_;