Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: chrome/browser/extensions/extension_apitest.h

Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/content_script_apitest.cc ('k') | chrome/browser/extensions/extension_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_apitest.h
diff --git a/chrome/browser/extensions/extension_apitest.h b/chrome/browser/extensions/extension_apitest.h
index cba4f5f1ecfc931146883c92d5a5041ab9a70691..4664878032c78025aaec294f5d5ae18ed0250df8 100644
--- a/chrome/browser/extensions/extension_apitest.h
+++ b/chrome/browser/extensions/extension_apitest.h
@@ -64,47 +64,7 @@ class ExtensionApiTest : public ExtensionBrowserTest {
virtual ~ExtensionApiTest();
protected:
- // Helper class that observes tests failing or passing. Observation starts
- // when the class is constructed. Get the next result by calling
- // GetNextResult() and message() if GetNextResult() return false. If there
- // are no results, this method will pump the UI message loop until one is
- // received.
- // DEPRECATED: Use extensions/test/result_catcher.h instead.
- class ResultCatcher : public content::NotificationObserver {
- public:
- ResultCatcher();
- virtual ~ResultCatcher();
-
- // Pumps the UI loop until a notification is received that an API test
- // succeeded or failed. Returns true if the test succeeded, false otherwise.
- bool GetNextResult();
-
- void RestrictToProfile(Profile* profile) { profile_restriction_ = profile; }
-
- const std::string& message() { return message_; }
-
- private:
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) OVERRIDE;
-
- content::NotificationRegistrar registrar_;
-
- // A sequential list of pass/fail notifications from the test extension(s).
- std::deque<bool> results_;
-
- // If it failed, what was the error message?
- std::deque<std::string> messages_;
- std::string message_;
-
- // If non-NULL, we will listen to events from this profile only.
- Profile* profile_restriction_;
-
- // True if we're in a nested message loop waiting for results from
- // the extension.
- bool waiting_;
- };
-
+ // InProcessBrowserTest:
virtual void SetUpInProcessBrowserTestFixture() OVERRIDE;
virtual void TearDownInProcessBrowserTestFixture() OVERRIDE;
« no previous file with comments | « chrome/browser/extensions/content_script_apitest.cc ('k') | chrome/browser/extensions/extension_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698