chrome/browser/apps/ephemeral_app_browsertest.cc - Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/ephemeral_app_browsertest.cc

Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/app_window_interactive_uitest.cc ('k') | chrome/browser/chromeos/extensions/accessibility_features_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/ephemeral_app_browsertest.cc

diff --git a/chrome/browser/apps/ephemeral_app_browsertest.cc b/chrome/browser/apps/ephemeral_app_browsertest.cc

index 690f11b4b09838f6bb687e528f27923a745c0a51..41afd9373115f848d6707a542a8e20dd7d46b345 100644

--- a/chrome/browser/apps/ephemeral_app_browsertest.cc

+++ b/chrome/browser/apps/ephemeral_app_browsertest.cc

@@ -39,6 +39,7 @@

#include "extensions/browser/uninstall_reason.h"

#include "extensions/common/extension.h"

#include "extensions/common/switches.h"

+#include "extensions/test/result_catcher.h"

#include "sync/api/fake_sync_change_processor.h"

#include "sync/api/sync_change_processor_wrapper_for_test.h"

#include "sync/api/sync_error_factory_mock.h"

@@ -54,6 +55,7 @@ using extensions::ExtensionRegistry;

using extensions::ExtensionRegistryObserver;

using extensions::ExtensionSystem;

using extensions::Manifest;

+using extensions::ResultCatcher;

namespace {

@@ -609,7 +611,7 @@ IN_PROC_BROWSER_TEST_F(EphemeralAppBrowserTest,

ASSERT_TRUE(receiver);

// Verify that messages are received while the app is running.

- ExtensionApiTest::ResultCatcher result_catcher;

+ ResultCatcher result_catcher;

LoadAndLaunchPlatformApp("ephemeral_apps/messaging_sender_success",

"Launched");

EXPECT_TRUE(result_catcher.GetNextResult());