chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc - Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/sockets_tcp/sockets_tcp_apitest.cc ('k') | chrome/browser/extensions/api/sockets_udp/sockets_udp_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

diff --git a/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc b/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

index 8043b7bfe76e2009b30b39a3efc7aaf1622a01d7..e74eed8b0effd448feb496eaa92f6146a31f94d6 100644

--- a/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

+++ b/chrome/browser/extensions/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

@@ -17,6 +17,7 @@

#include "extensions/browser/api/dns/host_resolver_wrapper.h"

#include "extensions/browser/api/dns/mock_host_resolver_creator.h"

#include "extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h"

+#include "extensions/test/result_catcher.h"

#include "net/dns/mock_host_resolver.h"

#include "net/test/spawned_test_server/spawned_test_server.h"

@@ -86,8 +87,8 @@ IN_PROC_BROWSER_TEST_F(SocketsTcpServerApiTest, SocketTCPCreateGood) {

IN_PROC_BROWSER_TEST_F(SocketsTcpServerApiTest, SocketTCPServerExtension) {

base::FilePath path = test_data_dir_.AppendASCII("sockets_tcp_server/api");

- ResultCatcher catcher;

- catcher.RestrictToProfile(browser()->profile());

+ extensions::ResultCatcher catcher;

+ catcher.RestrictToBrowserContext(browser()->profile());

ExtensionTestMessageListener listener("info_please", true);

ASSERT_TRUE(LoadExtension(path));

EXPECT_TRUE(listener.WaitUntilSatisfied());

@@ -99,7 +100,7 @@ IN_PROC_BROWSER_TEST_F(SocketsTcpServerApiTest, SocketTCPServerExtension) {

IN_PROC_BROWSER_TEST_F(SocketsTcpServerApiTest, SocketTCPServerUnbindOnUnload) {

base::FilePath path = test_data_dir_.AppendASCII("sockets_tcp_server/unload");

- ResultCatcher catcher;

+ extensions::ResultCatcher catcher;

const Extension* extension = LoadExtension(path);

ASSERT_TRUE(extension);

EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();