chrome/browser/extensions/api/dial/dial_apitest.cc - Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/dial/dial_apitest.cc

Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/context_menus/context_menu_apitest.cc ('k') | chrome/browser/extensions/api/extension_action/browser_action_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/dial/dial_apitest.cc

diff --git a/chrome/browser/extensions/api/dial/dial_apitest.cc b/chrome/browser/extensions/api/dial/dial_apitest.cc

index b86d59bd813bb78e7ff1d39ed40e89364e222843..872b3ca03950c006df9627c92cd05525db059856 100644

--- a/chrome/browser/extensions/api/dial/dial_apitest.cc

+++ b/chrome/browser/extensions/api/dial/dial_apitest.cc

@@ -10,6 +10,7 @@

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/extension_test_message_listener.h"

#include "extensions/common/switches.h"

+#include "extensions/test/result_catcher.h"

#include "testing/gmock/include/gmock/gmock.h"

#include "url/gurl.h"

@@ -52,7 +53,7 @@ IN_PROC_BROWSER_TEST_F(DialAPITest, MAYBE_DeviceListEvents) {

ASSERT_TRUE(api.get());

extensions::DialRegistry::DeviceList devices;

- ResultCatcher catcher;

+ extensions::ResultCatcher catcher;

DialDeviceData device1;

device1.set_device_id("1");

@@ -94,8 +95,8 @@ IN_PROC_BROWSER_TEST_F(DialAPITest, DiscoveryNoListeners) {

// Make sure this API is only accessible to whitelisted extensions.

IN_PROC_BROWSER_TEST_F(DialAPITest, NonWhitelistedExtension) {

- ResultCatcher catcher;

- catcher.RestrictToProfile(browser()->profile());

+ extensions::ResultCatcher catcher;

+ catcher.RestrictToBrowserContext(browser()->profile());

ExtensionTestMessageListener listener("ready", true);

const extensions::Extension* extension = LoadExtensionWithFlags(