chrome/browser/extensions/api/i18n/i18n_apitest.cc - Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/i18n/i18n_apitest.cc

Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/i18n/i18n_apitest.cc

diff --git a/chrome/browser/extensions/api/i18n/i18n_apitest.cc b/chrome/browser/extensions/api/i18n/i18n_apitest.cc

index 8d7cde3c23b7d50e8fc58ae0174e7b85c0577b69..96c3605f28a9c3d47c0cf91609a315568b7c96e1 100644

--- a/chrome/browser/extensions/api/i18n/i18n_apitest.cc

+++ b/chrome/browser/extensions/api/i18n/i18n_apitest.cc

@@ -10,6 +10,7 @@

#include "chrome/browser/ui/browser.h"

#include "chrome/test/base/ui_test_utils.h"

#include "extensions/common/extension.h"

+#include "extensions/test/result_catcher.h"

#include "net/test/embedded_test_server/embedded_test_server.h"

IN_PROC_BROWSER_TEST_F(ExtensionApiTest, I18N) {

@@ -38,7 +39,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, I18NUpdate) {

const extensions::Extension* extension = LoadExtension(extension_dir.path());

- ResultCatcher catcher;

+ extensions::ResultCatcher catcher;

// Test that the messages.json file is loaded and the i18n message is loaded.

ui_test_utils::NavigateToURL(

« no previous file with comments | « chrome/browser/extensions/api/gcm/gcm_apitest.cc ('k') | chrome/browser/extensions/api/mdns/mdns_apitest.cc » ('j') | no next file with comments »