chrome/browser/extensions/api/mdns/mdns_apitest.cc - Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/mdns/mdns_apitest.cc

Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/i18n/i18n_apitest.cc ('k') | chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/mdns/mdns_apitest.cc

diff --git a/chrome/browser/extensions/api/mdns/mdns_apitest.cc b/chrome/browser/extensions/api/mdns/mdns_apitest.cc

index 411d3ce6f87472fb5f5365aa4a1267947a4027df..4be0607e36c8f4e607350daaccf81c670e3fe103 100644

--- a/chrome/browser/extensions/api/mdns/mdns_apitest.cc

+++ b/chrome/browser/extensions/api/mdns/mdns_apitest.cc

@@ -8,6 +8,7 @@

#include "chrome/browser/extensions/extension_service.h"

#include "chrome/common/extensions/api/mdns.h"

#include "extensions/common/switches.h"

+#include "extensions/test/result_catcher.h"

#include "testing/gmock/include/gmock/gmock.h"

using extensions::DnsSdRegistry;

@@ -85,7 +86,7 @@ IN_PROC_BROWSER_TEST_F(MDnsAPITest, MAYBE_RegisterListener) {

EXPECT_TRUE(RunExtensionSubtest("mdns/api", "register_listener.html"))

<< message_;

- ResultCatcher catcher;

+ extensions::ResultCatcher catcher;

// Dispatch 3 events, one of which should not be sent to the test extension.

DnsSdRegistry::DnsSdServiceList services;

@@ -128,7 +129,7 @@ IN_PROC_BROWSER_TEST_F(MDnsAPITest, MAYBE_RegisterMultipleListeners) {

"register_multiple_listeners.html"))

<< message_;

- ResultCatcher catcher;

+ extensions::ResultCatcher catcher;

DnsSdRegistry::DnsSdServiceList services;

extensions::DnsSdService service;