extensions/browser/api/cast_channel/cast_channel_apitest.cc - Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/cast_channel_apitest.cc

Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/bluetooth_socket/bluetooth_socket_apitest.cc ('k') | extensions/browser/api/runtime/runtime_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/cast_channel/cast_channel_apitest.cc

diff --git a/extensions/browser/api/cast_channel/cast_channel_apitest.cc b/extensions/browser/api/cast_channel/cast_channel_apitest.cc

index 322a547d22ac152a4e843898cc4a5b64fb1b24c2..289c71e6c6a06d9efb9f3bde713ed441b69d57aa 100644

--- a/extensions/browser/api/cast_channel/cast_channel_apitest.cc

+++ b/extensions/browser/api/cast_channel/cast_channel_apitest.cc

@@ -15,6 +15,7 @@

#include "extensions/browser/api/cast_channel/logger.h"

#include "extensions/common/api/cast_channel.h"

#include "extensions/common/switches.h"

+#include "extensions/test/result_catcher.h"

#include "net/base/capturing_net_log.h"

#include "net/base/completion_callback.h"

#include "net/base/net_errors.h"

@@ -247,7 +248,7 @@ IN_PROC_BROWSER_TEST_F(CastChannelAPITest, MAYBE_TestOpenReceiveClose) {

EXPECT_TRUE(RunExtensionSubtest("cast_channel/api",

"test_open_receive_close.html"));

- ResultCatcher catcher;

+ extensions::ResultCatcher catcher;

CallOnMessage("some-message");

EXPECT_TRUE(catcher.GetNextResult()) << catcher.message();