extensions/browser/api/runtime/runtime_apitest.cc - Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/runtime/runtime_apitest.cc

Issue 555633003: Use extensions::ResultCatcher; delete ExtensionApiTest::ResultCatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/cast_channel/cast_channel_apitest.cc ('k') | extensions/browser/api/serial/serial_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/runtime/runtime_apitest.cc

diff --git a/extensions/browser/api/runtime/runtime_apitest.cc b/extensions/browser/api/runtime/runtime_apitest.cc

index 2f92756106c9fab52b1d495b9d605ad9fbc96dd0..764e22e28894554179530d5fbf809243ba82a661 100644

--- a/extensions/browser/api/runtime/runtime_apitest.cc

+++ b/extensions/browser/api/runtime/runtime_apitest.cc

@@ -11,6 +11,7 @@

#include "content/public/browser/notification_service.h"

#include "extensions/browser/api/runtime/runtime_api.h"

#include "extensions/browser/extension_registry.h"

+#include "extensions/test/result_catcher.h"

#include "net/test/embedded_test_server/embedded_test_server.h"

// Tests the privileged components of chrome.runtime.

@@ -25,7 +26,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, ChromeRuntimeUnprivileged) {

LoadExtension(test_data_dir_.AppendASCII("runtime/content_script")));

// The content script runs on webpage.html.

- ResultCatcher catcher;

+ extensions::ResultCatcher catcher;

ui_test_utils::NavigateToURL(browser(),

embedded_test_server()->GetURL("/webpage.html"));

EXPECT_TRUE(catcher.GetNextResult()) << message_;

« no previous file with comments | « extensions/browser/api/cast_channel/cast_channel_apitest.cc ('k') | extensions/browser/api/serial/serial_apitest.cc » ('j') | no next file with comments »