Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 533483004: Implement RenderWidgetHostViewAndroid::GetLastScrollOffset (Closed)

Created:
6 years, 3 months ago by Fady Samuel
Modified:
6 years, 3 months ago
Reviewers:
whywhat, timvolodine
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Implement RenderWidgetHostViewAndroid::GetLastScrollOffset Apparently this code was being hit on Android. This CL implements the scroll offset the same way it's implemented on other platforms. BUG=409792 NOTRY=true TBR=aelias@chromium.org Committed: https://crrev.com/2fc7bab92c8d1bc81761e15cedd3d355e22edf1e Cr-Commit-Position: refs/heads/master@{#292956}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (5 generated)
whywhat
lgtm, though you need to correct the bug number to 409792 (s/30/40)
6 years, 3 months ago (2014-09-02 15:42:18 UTC) #2
whywhat
On 2014/09/02 15:42:18, whywhat wrote: > lgtm, though you need to correct the bug number ...
6 years, 3 months ago (2014-09-02 15:42:43 UTC) #3
timvolodine
lgtm
6 years, 3 months ago (2014-09-02 15:48:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/533483004/1
6 years, 3 months ago (2014-09-02 16:34:17 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-09-02 17:18:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/533483004/1
6 years, 3 months ago (2014-09-02 17:54:18 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 65d2af75cb766f14e2173ffe590e7d46c4a33868
6 years, 3 months ago (2014-09-02 17:55:58 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:19:23 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fc7bab92c8d1bc81761e15cedd3d355e22edf1e
Cr-Commit-Position: refs/heads/master@{#292956}

Powered by Google App Engine
This is Rietveld 408576698