Add custom tabs tests using intents with non-null sessions

Add custom tabs tests using intents with non-null sessions

All current tests either test the service side session creation without
launching intents or the UI customization with no sessions. This change
add a trivial test that uses a valid session to launch an intent and also
another more complex test that reloads a new URL in the same tab when the
same session is used inside the intent.

Note that the service side is interfaced directly through CustomTabConnection
and this doesn't exactly replicate the actual scenario since all calls come
from the same process.

Committed: https://crrev.com/a69c3f7ba69a30aef2143945b8b2bbf8e6421080
Cr-Commit-Position: refs/heads/master@{#342131}

[Yusuf, 2015-08-04 21:44:26]

yusufo@chromium.org changed reviewers:
+ newt@chromium.org

[newt (away), 2015-08-05 20:32:31]

lgtm after comments

https://codereview.chromium.org/1267243003/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java
(right):

https://codereview.chromium.org/1267243003/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java:73:
}, 200, 5000));
Swap these two integers? The function signature is

    public static boolean pollForUIThreadCriteria(final Criteria criteria, long
maxTimeoutMs,
            long checkIntervalMs)

https://codereview.chromium.org/1267243003/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java:92:
static ICustomTabsCallback newDummyCallback() {
suggestion: It's more flexible to put helper methods like this in a Util class
instead of a TestBase. That way, any test can access the method. Similarly
createMinimalCustomTabIntent() would work splendidly in a Util class.

[Yusuf, 2015-08-05 23:26:08]

https://codereview.chromium.org/1267243003/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java
(right):

https://codereview.chromium.org/1267243003/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java:73:
}, 200, 5000));
On 2015/08/05 20:32:31, newt wrote:
> Swap these two integers? The function signature is
> 
>     public static boolean pollForUIThreadCriteria(final Criteria criteria,
long
> maxTimeoutMs,
>             long checkIntervalMs)

Done.

https://codereview.chromium.org/1267243003/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java:92:
static ICustomTabsCallback newDummyCallback() {
On 2015/08/05 20:32:31, newt wrote:
> suggestion: It's more flexible to put helper methods like this in a Util class
> instead of a TestBase. That way, any test can access the method. Similarly
> createMinimalCustomTabIntent() would work splendidly in a Util class.

Done.

[Yusuf, 2015-08-05 23:26:13]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2015-08-05 23:26:13]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1267243003/#ps20001
(title: "Added utils class and moved two calls there, nits")

[commit-bot: I haz the power, 2015-08-05 23:26:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1267243003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1267243003/20001

[Yusuf, 2015-08-05 23:26:56]

The CQ bit was unchecked by yusufo@chromium.org

[Yusuf, 2015-08-06 16:54:29]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2015-08-06 16:54:29]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1267243003/#ps40001
(title: "Added the utils class")

[commit-bot: I haz the power, 2015-08-06 16:55:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1267243003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1267243003/40001

[commit-bot: I haz the power, 2015-08-06 17:00:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-06 17:01:20]

Patchset 3 (id:??) landed as
https://crrev.com/a69c3f7ba69a30aef2143945b8b2bbf8e6421080
Cr-Commit-Position: refs/heads/master@{#342131}

[Yusuf, 2015-08-06 19:04:29]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1276993002/ by yusufo@chromium.org.

The reason for reverting is: Test flaking on dowsntream ToT due to deferred
startup not finishing..