Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 1231883003: Add a string for Chrome branding (Closed)

Created:
5 years, 5 months ago by Yusuf
Modified:
5 years, 5 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a string for Chrome branding This is to be used in cased where we want to prompt the user with context and signal that the current UI belongs to Chrome. BUG=507522 Committed: https://crrev.com/7b17c3e5a64eda068d88aa03739b1205863d884a Cr-Commit-Position: refs/heads/master@{#338118}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/android/java/strings/android_chrome_strings.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
Yusuf
5 years, 5 months ago (2015-07-09 17:46:44 UTC) #2
newt (away)
comment, then lgtm https://codereview.chromium.org/1231883003/diff/1/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/1231883003/diff/1/chrome/android/java/strings/android_chrome_strings.grd#newcode799 chrome/android/java/strings/android_chrome_strings.grd:799: <message name="IDS_CHROME_BRANDING_MESSAGE" desc="The branding message for ...
5 years, 5 months ago (2015-07-09 18:55:59 UTC) #3
Yusuf
https://codereview.chromium.org/1231883003/diff/1/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/1231883003/diff/1/chrome/android/java/strings/android_chrome_strings.grd#newcode799 chrome/android/java/strings/android_chrome_strings.grd:799: <message name="IDS_CHROME_BRANDING_MESSAGE" desc="The branding message for prompting user with ...
5 years, 5 months ago (2015-07-09 18:57:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1231883003/20001
5 years, 5 months ago (2015-07-09 18:58:32 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-09 19:39:58 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-09 19:41:01 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b17c3e5a64eda068d88aa03739b1205863d884a
Cr-Commit-Position: refs/heads/master@{#338118}

Powered by Google App Engine
This is Rietveld 408576698