Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 1254423006: Add getThemeColor to Tab and add plumbing for ChromeActivites. (Closed)

Created:
5 years, 4 months ago by Yusuf
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add getThemeColor to Tab and add plumbing for ChromeActivites. Moves all theme color computing logic to tab. Adds the necessary update signals to ChromeActivity and adds an onUpdate call to be overridden by extending classes. The main outcome of all this is, all ChromeActivities become color change aware. Doesn't add any visual changes. Yet. BUG=507340 Committed: https://crrev.com/25d23c547cd7661fe2e679d74e4272917dae2985 Cr-Commit-Position: refs/heads/master@{#341226}

Patch Set 1 #

Patch Set 2 : Added missing interstital page reset #

Patch Set 3 : Make sure activity exists for referencing resources #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -47 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 1 5 chunks +43 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java View 7 chunks +10 lines, -47 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java View 1 2 6 chunks +28 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (5 generated)
Yusuf
5 years, 4 months ago (2015-07-30 20:06:15 UTC) #2
David Trainor- moved to gerrit
lgtm
5 years, 4 months ago (2015-07-30 21:07:46 UTC) #3
Yusuf
I had accidentally removed resetting on interstitial pages and caught that while running tests. Would ...
5 years, 4 months ago (2015-07-30 21:56:35 UTC) #4
David Trainor- moved to gerrit
lgtm
5 years, 4 months ago (2015-07-30 22:16:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254423006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254423006/20001
5 years, 4 months ago (2015-07-30 22:19:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/103107)
5 years, 4 months ago (2015-07-30 22:50:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254423006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254423006/40001
5 years, 4 months ago (2015-07-30 23:03:59 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-07-30 23:45:50 UTC) #13
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/25d23c547cd7661fe2e679d74e4272917dae2985 Cr-Commit-Position: refs/heads/master@{#341226}
5 years, 4 months ago (2015-07-30 23:46:41 UTC) #14
Fabrice (no longer in Chrome)
5 years, 4 months ago (2015-07-31 15:13:33 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1260523004/ by fdegans@chromium.org.

The reason for reverting is: Speculative revert.
This seems to have broken
BrandColorTest.testBrandColorInterstitial
BrandColorTest.testNavigatingToBrandColorAndBack
BrandColorTest.testNoBrandColor
on Lollipop in Document Mde..

Powered by Google App Engine
This is Rietveld 408576698