Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1260693007: Export CustomTabsConnectionService in all channels (Closed)

Created:
5 years, 4 months ago by Yusuf
Modified:
5 years, 4 months ago
Reviewers:
newt (away)
CC:
chromium-reviews, Benoit L, Ian Wen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Export CustomTabsConnectionService in all channels Now that we have Custom Tabs confirmed for m45, export the service in all channels. This currently breaks beta implementation giving early adopters a SecurityException. BUG=516874 Committed: https://crrev.com/d7d0894bef96ad7349d4089a0dc3a16c3b9c5e9f Cr-Commit-Position: refs/heads/master@{#341832}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/java/AndroidManifest.xml View 1 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
Yusuf
5 years, 4 months ago (2015-08-04 23:49:02 UTC) #2
newt (away)
lgtm https://codereview.chromium.org/1260693007/diff/1/chrome/android/java/AndroidManifest.xml File chrome/android/java/AndroidManifest.xml (right): https://codereview.chromium.org/1260693007/diff/1/chrome/android/java/AndroidManifest.xml#newcode553 chrome/android/java/AndroidManifest.xml:553: android:exported="true" funky indentation
5 years, 4 months ago (2015-08-04 23:51:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1260693007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1260693007/20001
5 years, 4 months ago (2015-08-04 23:53:05 UTC) #6
Yusuf
5 years, 4 months ago (2015-08-04 23:54:55 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-05 00:30:59 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 00:34:50 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d7d0894bef96ad7349d4089a0dc3a16c3b9c5e9f
Cr-Commit-Position: refs/heads/master@{#341832}

Powered by Google App Engine
This is Rietveld 408576698