Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2450)

Issue 1223023002: Check whether a second intent should be ignored in custom tabs (Closed)

Created:
5 years, 5 months ago by Yusuf
Modified:
5 years, 5 months ago
Reviewers:
Ted C
CC:
chromium-reviews, ianwen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check whether a second intent should be ignored in custom tabs A custom tab can clobber a second intent that comes with the same session id. When this happens we should be using IntentHandler#shouldIgnoreIntent to check the validity of the intent like we do in ChromeActivity#onNewIntentWithNative BUG=507976 Committed: https://crrev.com/466bf49ffe26f66554e044fd1e9dbb29665bb7ac Cr-Commit-Position: refs/heads/master@{#337879}

Patch Set 1 #

Patch Set 2 : Added a log when an intent was ignored #

Patch Set 3 : Fixed compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 4 chunks +12 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabContentHandler.java View 2 chunks +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
Yusuf
5 years, 5 months ago (2015-07-08 17:36:38 UTC) #2
Ted C
lgtm
5 years, 5 months ago (2015-07-08 17:39:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223023002/20001
5 years, 5 months ago (2015-07-08 17:44:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/94692) (exceeded global retry quota)
5 years, 5 months ago (2015-07-08 17:58:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1223023002/40001
5 years, 5 months ago (2015-07-08 18:44:39 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-08 19:24:38 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-08 19:26:36 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/466bf49ffe26f66554e044fd1e9dbb29665bb7ac
Cr-Commit-Position: refs/heads/master@{#337879}

Powered by Google App Engine
This is Rietveld 408576698