Reland : Add custom tabs tests using intents with non-null sessions

Reland : Add custom tabs tests using intents with non-null sessions

All current tests either test the service side session creation without
launching intents or the UI customization with no sessions. This change
add a trivial test that uses a valid session to launch an intent and also
another more complex test that reloads a new URL in the same tab when the
same session is used inside the intent.

Note that the service side is interfaced directly through CustomTabConnection
and this doesn't exactly replicate the actual scenario since all calls come
from the same process.

Committed: https://crrev.com/b3131d5bf11ef55dbbb54c0e84ae4bdb787a7ec2
Cr-Commit-Position: refs/heads/master@{#342721}

[Yusuf, 2015-08-07 18:39:16]

yusufo@chromium.org changed reviewers:
+ newt@chromium.org

[Yusuf, 2015-08-07 18:39:16]

Relanding https://codereview.chromium.org/1267243003/

This was reverted because of a timeout with deferred startup.

Added more steps in the initialization (sync initialization complete and page
load finished) to have more granularity for potential flakes and failures in the
future. Also this distributes the waits over a bit more distinct intervals.

PTAL

[newt (away), 2015-08-10 19:59:23]

lgtm

https://codereview.chromium.org/1278473005/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
(right):

https://codereview.chromium.org/1278473005/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java:406:
return mActivity.getActivityTab().getUrl().equals(TEST_PAGE);
should you wait for the page to finish loading?

https://codereview.chromium.org/1278473005/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java:441:
fail();
indentation

[Yusuf, 2015-08-10 20:40:55]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2015-08-10 20:40:55]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1278473005/#ps20001
(title: "nits")

[Yusuf, 2015-08-10 20:41:02]

https://codereview.chromium.org/1278473005/diff/1/chrome/android/javatests/sr...
File
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
(right):

https://codereview.chromium.org/1278473005/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java:406:
return mActivity.getActivityTab().getUrl().equals(TEST_PAGE);
On 2015/08/10 19:59:23, newt wrote:
> should you wait for the page to finish loading?

Done.

https://codereview.chromium.org/1278473005/diff/1/chrome/android/javatests/sr...
chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java:441:
fail();
On 2015/08/10 19:59:23, newt wrote:
> indentation

Done.

[commit-bot: I haz the power, 2015-08-10 20:41:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1278473005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1278473005/20001

[commit-bot: I haz the power, 2015-08-10 20:49:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-10 20:49:56]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yusuf, 2015-08-10 21:08:31]

The CQ bit was checked by yusufo@chromium.org

[commit-bot: I haz the power, 2015-08-10 21:09:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1278473005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1278473005/20001

[commit-bot: I haz the power, 2015-08-10 22:12:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-10 22:12:26]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[Yusuf, 2015-08-10 22:27:19]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2015-08-10 22:27:19]

The patchset sent to the CQ was uploaded after l-g-t-m from newt@chromium.org
Link to the patchset: https://codereview.chromium.org/1278473005/#ps40001
(title: "Add startup callback on UI thread.")

[commit-bot: I haz the power, 2015-08-10 22:27:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1278473005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1278473005/40001

[commit-bot: I haz the power, 2015-08-10 22:57:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-10 22:57:53]

Patchset 3 (id:??) landed as
https://crrev.com/b3131d5bf11ef55dbbb54c0e84ae4bdb787a7ec2
Cr-Commit-Position: refs/heads/master@{#342721}