Issue 1259863005: Check first run finished before service connection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1259863005: Check first run finished before service connection (Closed)

Created:
5 years, 4 months ago by Yusuf

Modified:
5 years, 4 months ago

Reviewers:
Ian Wen, Benoit L

CC:
chromium-reviews, ianwen+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Check first run finished before service connection This avoid connecting to custom tabs service before the user acknowledges ToS BUG=515654

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnectionService.java	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Depends on Patchset:

Total messages: 4 (1 generated)

Benoit L

lgtm However, I wonder whether this will expose application bugs.

5 years, 4 months ago (2015-07-31 11:16:13 UTC) #3

Ian Wen

5 years, 4 months ago (2015-07-31 17:19:03 UTC) #4

We still need a proper way to let FRE show in ChromeLauncherActivity. Currently
custom tab's initialization happens before the FRE.