Issue 1233913006: Cleanup toolbar interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1233913006: Cleanup toolbar interface (Closed)

Created:
5 years, 5 months ago by Yusuf

Modified:
5 years, 5 months ago

Reviewers:
Ted C

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Cleanup toolbar interface Remove the methods only used by ToolbarManager or ToolbarLayout classes from the public interface Committed: https://crrev.com/dd927c18081ef420b886f47d318db868696710be Cr-Commit-Position: refs/heads/master@{#339165}

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -75 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/toolbar/Toolbar.java	View		2 chunks	+1 line, -65 lines	0 comments	Download
	M	chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java	View		7 chunks	+38 lines, -10 lines	0 comments	Download

Depends on Patchset:

Issue 533483004 Patch 1

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1233913006/1

5 years, 5 months ago (2015-07-16 22:40:01 UTC) #5

commit-bot: I haz the power

5 years, 5 months ago (2015-07-16 23:28:44 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/dd927c18081ef420b886f47d318db868696710be
Cr-Commit-Position: refs/heads/master@{#339165}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages