Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1278603002: Roll third_party/custom_tabs_client (Closed)

Created:
5 years, 4 months ago by Yusuf
Modified:
5 years, 4 months ago
Reviewers:
Ian Wen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll third_party/custom_tabs_client This fixes a crash on Android versions below API 18 BUG=510083 Committed: https://crrev.com/8fe412f0caf272435d1d68f531fdb8088225255e Cr-Commit-Position: refs/heads/master@{#342041}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (4 generated)
Yusuf
5 years, 4 months ago (2015-08-05 21:50:57 UTC) #2
Ian Wen
lgtm
5 years, 4 months ago (2015-08-05 22:32:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278603002/1
5 years, 4 months ago (2015-08-05 22:33:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/52473)
5 years, 4 months ago (2015-08-05 23:55:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1278603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1278603002/1
5 years, 4 months ago (2015-08-06 00:00:02 UTC) #9
Ian Wen
Oops that's embarrassing. One test that I wrote flaked..
5 years, 4 months ago (2015-08-06 00:02:14 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-06 01:24:37 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 01:25:16 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8fe412f0caf272435d1d68f531fdb8088225255e
Cr-Commit-Position: refs/heads/master@{#342041}

Powered by Google App Engine
This is Rietveld 408576698