Make showing the page title in a custom tab a dev option

Make showing the page title in a custom tab a dev option

This defaults to showing only the url in a custom tab and gives
an extra to customize it, so that page title shows. We make the
change in postInflationLayout so that we dont get an extra measure.

BUG=504045
Committed: https://crrev.com/ffdd7b0f8752de02a9292c15abf2912f67b627e4
Cr-Commit-Position: refs/heads/master@{#336483}

[Yusuf, 2015-06-26 00:17:07]

yusufo@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Ted C, 2015-06-26 22:51:00]

https://codereview.chromium.org/1214553002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
(right):

https://codereview.chromium.org/1214553002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java:129:
private final int mTitleVisibilityState;
I would put this above mToolbarColor to keep the finals together

https://codereview.chromium.org/1214553002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
(right):

https://codereview.chromium.org/1214553002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java:197:
setTitleToPageTitle(false);
this api is weird.  it is odd that the boolean is only used if true, and if
false it is not hiding the title.  I think we probably should have a separate
method altogether.

https://codereview.chromium.org/1214553002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
(right):

https://codereview.chromium.org/1214553002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java:807:
public void setTitleVisibilityState(int titleVisibilityState) {
this should be setShowTitle.  Keep the CUSTOM_TABS into above isolated into the
custom tabs activity.

[Yusuf, 2015-06-26 23:20:14]

https://codereview.chromium.org/1214553002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
(right):

https://codereview.chromium.org/1214553002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java:129:
private final int mTitleVisibilityState;
On 2015/06/26 22:51:00, Ted C wrote:
> I would put this above mToolbarColor to keep the finals together

Done.

https://codereview.chromium.org/1214553002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
(right):

https://codereview.chromium.org/1214553002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java:197:
setTitleToPageTitle(false);
On 2015/06/26 22:51:00, Ted C wrote:
> this api is weird.  it is odd that the boolean is only used if true, and if
> false it is not hiding the title.  I think we probably should have a separate
> method altogether.

Done.

https://codereview.chromium.org/1214553002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java
(right):

https://codereview.chromium.org/1214553002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java:807:
public void setTitleVisibilityState(int titleVisibilityState) {
On 2015/06/26 22:51:00, Ted C wrote:
> this should be setShowTitle.  Keep the CUSTOM_TABS into above isolated into
the
> custom tabs activity.

Done.

[Ted C, 2015-06-26 23:36:45]

lgtm

[Yusuf, 2015-06-26 23:40:41]

The CQ bit was checked by yusufo@chromium.org

[commit-bot: I haz the power, 2015-06-26 23:40:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1214553002/20001

[Yusuf, 2015-06-26 23:49:05]

The CQ bit was unchecked by yusufo@chromium.org

[Yusuf, 2015-06-26 23:50:57]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2015-06-26 23:50:58]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/1214553002/#ps40001
(title: "Made the added constants final")

[commit-bot: I haz the power, 2015-06-26 23:51:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1214553002/40001

[commit-bot: I haz the power, 2015-06-27 00:27:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-27 00:28:46]

Patchset 3 (id:??) landed as
https://crrev.com/ffdd7b0f8752de02a9292c15abf2912f67b627e4
Cr-Commit-Position: refs/heads/master@{#336483}