Revert "Revert of Add getThemeColor to Tab and add plumbing for ChromeActivites. (patchset #3 id:40…

Revert "Revert of Add getThemeColor to Tab and add plumbing for ChromeActivites. (patchset #3 id:40001 of https://codereview.chromium.org/1254423006/)"

This reverts commit 622bf10486216f89aaa3df8cd02a3daec638a53f.
Fixed the issue on the original CL. The change for fixing
findbugs beof rethe patch landed, made the color default to
black in most cases.

BUG=507340

[Yusuf, 2015-07-31 18:32:50]

yusufo@chromium.org changed reviewers:
+ dtrainor@chromium.org

[Yusuf, 2015-07-31 18:32:50]

PTAL, I had broken everything else when I fixed findbugs in the original CL.
Fixed, and retested now.

[Yusuf, 2015-07-31 18:33:25]

Original CL: https://codereview.chromium.org/1254423006/

[David Trainor- moved to gerrit, 2015-07-31 21:07:59]

lgtm with slight sadness!

https://chromiumcodereview.appspot.com/1262863003/diff/1/chrome/android/java/...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://chromiumcodereview.appspot.com/1262863003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:506:
public void onDidChangeThemeColor(int color) {
It's sad that we can't actually rely on color here :(.

[Yusuf, 2015-07-31 21:12:14]

https://chromiumcodereview.appspot.com/1262863003/diff/1/chrome/android/java/...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://chromiumcodereview.appspot.com/1262863003/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:506:
public void onDidChangeThemeColor(int color) {
On 2015/07/31 21:07:59, David Trainor wrote:
> It's sad that we can't actually rely on color here :(.

Yeah... It is mostly the security related bits that makes us not believe this
immediately which are all in chrome/, so can't really add that logic to web
contents.

Would you have been happier with a solution that does a similar caching on the
tab level and then only pushes this update when it really changes?

So mostly move all this logic inside tab and override the tabobserver call to
only ping when we want to propagate that change.

[Yusuf, 2015-08-03 05:53:28]

https://codereview.chromium.org/1262863003/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
(right):

https://codereview.chromium.org/1262863003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:506:
public void onDidChangeThemeColor(int color) {
On 2015/07/31 21:12:14, Yusuf wrote:
> On 2015/07/31 21:07:59, David Trainor wrote:
> > It's sad that we can't actually rely on color here :(.
> 
> Yeah... It is mostly the security related bits that makes us not believe this
> immediately which are all in chrome/, so can't really add that logic to web
> contents.
> 
> Would you have been happier with a solution that does a similar caching on the
> tab level and then only pushes this update when it really changes?
> 
> So mostly move all this logic inside tab and override the tabobserver call to
> only ping when we want to propagate that change.

Abandoning this in favor of https://codereview.chromium.org/1254783003/.