Add a slide animation to security lock appearing on a custom tab

Add a slide animation to security lock appearing on a custom tab

Slides the url_info_container that contains both url and potentially title.
Then makes the security lock visible and fades it in.

BUG=505620
Committed: https://crrev.com/cc92a1f6750f43105dc09fb44a3806e381ae1074
Cr-Commit-Position: refs/heads/master@{#337112}

[Yusuf, 2015-06-29 22:27:00]

yusufo@chromium.org changed reviewers:
+ tedchoc@chromium.org

[Ted C, 2015-07-01 17:47:34]

https://codereview.chromium.org/1218923002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
(right):

https://codereview.chromium.org/1218923002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java:103:
ObjectAnimator.ofFloat(mUrlInfoContainer, TRANSLATION_X,
securityIconButtonWidth);
what about in rtl mode?  Do you need to translate the other way?

https://codereview.chromium.org/1218923002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java:105:
Animator securityButtonAlphaAnimator = ObjectAnimator.ofFloat(mSecurityButton,
ALPHA, 1);
I would put a blank line above this to split up the two animators

https://codereview.chromium.org/1218923002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java:114:
mSecurityButtonShowAnimator.playSequentially(
blank line above this as well.

https://codereview.chromium.org/1218923002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java:117:
.setDuration(CUSTOM_TAB_TOOLBAR_ANIMATION_DURATION_MS);
does this set the duration of each one to 300 ms?  The total duration?  How does
it split the time?

if it's 300 each, then 600ms is really long

[Yusuf, 2015-07-01 20:18:02]

https://codereview.chromium.org/1218923002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java
(right):

https://codereview.chromium.org/1218923002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java:103:
ObjectAnimator.ofFloat(mUrlInfoContainer, TRANSLATION_X,
securityIconButtonWidth);
On 2015/07/01 17:47:33, Ted C wrote:
> what about in rtl mode?  Do you need to translate the other way?

Turns out RTL is broken in ways that can not be fixed within this CL. Filed
crbug.com/506326 to track that. For now I am not doing anything here.

https://codereview.chromium.org/1218923002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java:105:
Animator securityButtonAlphaAnimator = ObjectAnimator.ofFloat(mSecurityButton,
ALPHA, 1);
On 2015/07/01 17:47:33, Ted C wrote:
> I would put a blank line above this to split up the two animators

Done.

https://codereview.chromium.org/1218923002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java:114:
mSecurityButtonShowAnimator.playSequentially(
On 2015/07/01 17:47:33, Ted C wrote:
> blank line above this as well.

Done.

https://codereview.chromium.org/1218923002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java:117:
.setDuration(CUSTOM_TAB_TOOLBAR_ANIMATION_DURATION_MS);
On 2015/07/01 17:47:33, Ted C wrote:
> does this set the duration of each one to 300 ms?  The total duration?  How
does
> it split the time?
> 
> if it's 300 each, then 600ms is really long

Ended up with 200 for slide and 150 for fade in.

[Ted C, 2015-07-01 20:19:56]

lgtm

[Yusuf, 2015-07-01 20:39:12]

The CQ bit was checked by yusufo@chromium.org

[commit-bot: I haz the power, 2015-07-01 20:40:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1218923002/20001

[commit-bot: I haz the power, 2015-07-01 21:14:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-01 21:15:29]

Patchset 2 (id:??) landed as
https://crrev.com/cc92a1f6750f43105dc09fb44a3806e381ae1074
Cr-Commit-Position: refs/heads/master@{#337112}