Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1254783003: Move theme color logic to Tab (Closed)

Created:
5 years, 4 months ago by Yusuf
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move theme color logic to Tab Starts caching the theme color to be used inside tab. This value depends on whether the tab is incognito and also the security state and whether the tab is showing an interstitial page. Changes TabObserver#ondidChangeThemeColor so that in only pushes actually changes from the cached value. ChromeActivity starts listening for this signal and pushes any color changes to ToolbarManager making all ChromeActivity classes aware of theme color changes. This should still not cause any visual changes. BUG=507340 Committed: https://crrev.com/39b1ea70f1f923c763f31ce66dd783ed530dc39f Cr-Commit-Position: refs/heads/master@{#341559}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Nits #

Messages

Total messages: 9 (3 generated)
Yusuf
5 years, 4 months ago (2015-08-03 05:53:49 UTC) #2
David Trainor- moved to gerrit
lgtm with change to ChromeActivity and nit. https://chromiumcodereview.appspot.com/1254783003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java (right): https://chromiumcodereview.appspot.com/1254783003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java#newcode507 chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:507: public void ...
5 years, 4 months ago (2015-08-03 17:04:28 UTC) #3
Yusuf
https://codereview.chromium.org/1254783003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java (right): https://codereview.chromium.org/1254783003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java#newcode507 chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:507: public void onDidChangeThemeColor(Tab tab, int color) { On 2015/08/03 ...
5 years, 4 months ago (2015-08-03 17:46:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254783003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254783003/20001
5 years, 4 months ago (2015-08-03 17:48:35 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-03 18:29:21 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 18:30:00 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/39b1ea70f1f923c763f31ce66dd783ed530dc39f
Cr-Commit-Position: refs/heads/master@{#341559}

Powered by Google App Engine
This is Rietveld 408576698