Make Position::BeforeNode() to take const Node& instead of Node*

Make Position::BeforeNode() to take const Node& instead of Node*

This patch makes |Position::BeforeNode()| to take |const Node&| instead of
|Node*| since |Node| parameter can not be nullptr for improving code health.

This patch also changes |Position| constructor with |PositionAnchorType|
to take |const Node*| to reduce using |const_cast<Node*>()|.

This patch is a preparation of make |Position| to hold |const Node&|[1]

[1] http://crbug.com/735327 Position should hold const Node instead of Node

BUG=734849
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2950053002
Cr-Commit-Position: refs/heads/master@{#481342}
Committed: https://chromium.googlesource.com/chromium/src/+/f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb

[yosin_UTC9, 2017-06-21 08:57:57]

Description was changed from

==========
2017-06-21T17:56:36

BUG=

2017-06-21T17:56:27
==========

to

==========
2017-06-21T17:56:36

BUG=734849

2017-06-21T17:56:27
==========

[yosin_UTC9, 2017-06-21 09:00:00]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 09:00:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-06-21 09:04:12]

Description was changed from

==========
2017-06-21T17:56:36

BUG=734849

2017-06-21T17:56:27
==========

to

==========
Make Position::BeforeNode() to take const Node& instead of Node*

This patch makes |Position::BeforeNode()| to take |const Node&| instead of
|Node*| since |Node| parameter can not be nullptr for improving code health.

This patch also changes |Position| constructor with |PositionAnchorType|
to take |const Node*| to reduce using |const_cast<Node*>()|.

BUG=734849
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-06-21 09:32:51]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org

[yosin_UTC9, 2017-06-21 09:32:52]

PTAL

Including core/dom, core/editing, and core/html
Almost machinally s/:BeforeNode(/:BeforeNode(*/

[yosin_UTC9, 2017-06-21 09:34:01]

Description was changed from

==========
Make Position::BeforeNode() to take const Node& instead of Node*

This patch makes |Position::BeforeNode()| to take |const Node&| instead of
|Node*| since |Node| parameter can not be nullptr for improving code health.

This patch also changes |Position| constructor with |PositionAnchorType|
to take |const Node*| to reduce using |const_cast<Node*>()|.

BUG=734849
TEST=n/a; no behavior changes
==========

to

==========
Make Position::BeforeNode() to take const Node& instead of Node*

This patch makes |Position::BeforeNode()| to take |const Node&| instead of
|Node*| since |Node| parameter can not be nullptr for improving code health.

This patch also changes |Position| constructor with |PositionAnchorType|
to take |const Node*| to reduce using |const_cast<Node*>()|.

This patch is a preparation of make |Position| to hold |const Node&|[1]

[1] http://crbug.com/735327 ⚐	Position should hold const Node instead of Node

BUG=734849
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-06-21 09:34:33]

Description was changed from

==========
Make Position::BeforeNode() to take const Node& instead of Node*

This patch makes |Position::BeforeNode()| to take |const Node&| instead of
|Node*| since |Node| parameter can not be nullptr for improving code health.

This patch also changes |Position| constructor with |PositionAnchorType|
to take |const Node*| to reduce using |const_cast<Node*>()|.

This patch is a preparation of make |Position| to hold |const Node&|[1]

[1] http://crbug.com/735327 ⚐	Position should hold const Node instead of Node

BUG=734849
TEST=n/a; no behavior changes
==========

to

==========
Make Position::BeforeNode() to take const Node& instead of Node*

This patch makes |Position::BeforeNode()| to take |const Node&| instead of
|Node*| since |Node| parameter can not be nullptr for improving code health.

This patch also changes |Position| constructor with |PositionAnchorType|
to take |const Node*| to reduce using |const_cast<Node*>()|.

This patch is a preparation of make |Position| to hold |const Node&|[1]

[1] http://crbug.com/735327 Position should hold const Node instead of Node

BUG=734849
TEST=n/a; no behavior changes
==========

[commit-bot: I haz the power, 2017-06-21 11:27:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 11:27:42]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-06-21 22:47:06]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-06-21 22:47:06]

lgtm

[commit-bot: I haz the power, 2017-06-21 22:47:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 22:53:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498085226099870, "parent_rev":
"824e59ad42d8d0ef0f98f5409a1a1d9d18600539", "commit_rev":
"04ba08185b5d438510cf334f10845b6d7cfcd00f"}

[commit-bot: I haz the power, 2017-06-21 22:53:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1498085226099870, "parent_rev":
"54225d6563556bbfb1b4b7df5e59732026a52a0b", "commit_rev":
"f4c484ebaecb7e0e8b7135838b3e29f56cfe04fb"}

[commit-bot: I haz the power, 2017-06-21 22:53:49]

Description was changed from

==========
Make Position::BeforeNode() to take const Node& instead of Node*

This patch makes |Position::BeforeNode()| to take |const Node&| instead of
|Node*| since |Node| parameter can not be nullptr for improving code health.

This patch also changes |Position| constructor with |PositionAnchorType|
to take |const Node*| to reduce using |const_cast<Node*>()|.

This patch is a preparation of make |Position| to hold |const Node&|[1]

[1] http://crbug.com/735327 Position should hold const Node instead of Node

BUG=734849
TEST=n/a; no behavior changes
==========

to

==========
Make Position::BeforeNode() to take const Node& instead of Node*

This patch makes |Position::BeforeNode()| to take |const Node&| instead of
|Node*| since |Node| parameter can not be nullptr for improving code health.

This patch also changes |Position| constructor with |PositionAnchorType|
to take |const Node*| to reduce using |const_cast<Node*>()|.

This patch is a preparation of make |Position| to hold |const Node&|[1]

[1] http://crbug.com/735327 Position should hold const Node instead of Node

BUG=734849
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2950053002
Cr-Commit-Position: refs/heads/master@{#481342}
Committed:
https://chromium.googlesource.com/chromium/src/+/f4c484ebaecb7e0e8b7135838b3e...
==========

[commit-bot: I haz the power, 2017-06-21 22:53:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f4c484ebaecb7e0e8b7135838b3e...