third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp - Issue 2950053002: Make Position::BeforeNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp

Issue 2950053002: Make Position::BeforeNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-21T17:56:36 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/serializers/Serialization.cpp ('k') | third_party/WebKit/Source/core/html/TextControlElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp

diff --git a/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp b/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp

index 0b346d82730d89162924b20945d23518ca31246d..5b47b200935a9e0ee65f957569ff59162ed974fd 100644

--- a/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp

+++ b/third_party/WebKit/Source/core/editing/serializers/StyledMarkupSerializer.cpp

@@ -199,9 +199,9 @@ String StyledMarkupSerializer<Strategy>::CreateMarkup() {

first_node = NextPositionOf(visible_start).DeepEquivalent().AnchorNode();

- if (past_end && PositionTemplate<Strategy>::BeforeNode(first_node)

+ if (past_end && PositionTemplate<Strategy>::BeforeNode(*first_node)

.CompareTo(PositionTemplate<Strategy>::BeforeNode(

- past_end)) >= 0) {

+ *past_end)) >= 0) {

// This condition hits in editing/pasteboard/copy-display-none.html.

return markup_accumulator.TakeResults();

}