Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2252)

Unified Diff: third_party/WebKit/Source/core/editing/Position.h

Issue 2950053002: Make Position::BeforeNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-21T17:56:36 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/Position.h
diff --git a/third_party/WebKit/Source/core/editing/Position.h b/third_party/WebKit/Source/core/editing/Position.h
index 81a64ea1b89c96983ad159a6f512c467db3a1f9f..6fb44bcf15f8801acf763e517f08f917f39df073 100644
--- a/third_party/WebKit/Source/core/editing/Position.h
+++ b/third_party/WebKit/Source/core/editing/Position.h
@@ -67,7 +67,7 @@ class CORE_TEMPLATE_CLASS_EXPORT PositionTemplate {
int offset);
// For creating before/after positions:
- PositionTemplate(Node* anchor_node, PositionAnchorType);
+ PositionTemplate(const Node* anchor_node, PositionAnchorType);
// For creating offset positions:
PositionTemplate(const Node& anchor_node, int offset);
@@ -188,7 +188,7 @@ class CORE_TEMPLATE_CLASS_EXPORT PositionTemplate {
bool AtStartOfTree() const;
bool AtEndOfTree() const;
- static PositionTemplate<Strategy> BeforeNode(Node* anchor_node);
+ static PositionTemplate<Strategy> BeforeNode(const Node& anchor_node);
static PositionTemplate<Strategy> AfterNode(Node* anchor_node);
static PositionTemplate<Strategy> InParentBeforeNode(const Node& anchor_node);
static PositionTemplate<Strategy> InParentAfterNode(const Node& anchor_node);
« no previous file with comments | « third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp ('k') | third_party/WebKit/Source/core/editing/Position.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698