third_party/WebKit/Source/core/editing/VisibleUnitsParagraph.cpp - Issue 2950053002: Make Position::BeforeNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnitsParagraph.cpp

Issue 2950053002: Make Position::BeforeNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-21T17:56:36 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/VisibleUnitsParagraph.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisibleUnitsParagraph.cpp b/third_party/WebKit/Source/core/editing/VisibleUnitsParagraph.cpp

index e4eb2451876bbc98aa22715446e3d084ae4025f2..015d6e5ddbf73655ff94d808501f11756f42aaa3 100644

--- a/third_party/WebKit/Source/core/editing/VisibleUnitsParagraph.cpp

+++ b/third_party/WebKit/Source/core/editing/VisibleUnitsParagraph.cpp

@@ -53,7 +53,7 @@ PositionTemplate<Strategy> StartOfParagraphAlgorithm(

return PositionTemplate<Strategy>();

if (IsRenderedAsNonInlineTableImageOrHR(start_node))

- return PositionTemplate<Strategy>::BeforeNode(start_node);

+ return PositionTemplate<Strategy>::BeforeNode(*start_node);

Element* const start_block = EnclosingBlock(

PositionTemplate<Strategy>::FirstPositionInOrBeforeNode(start_node),