Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: third_party/WebKit/Source/core/editing/EditingUtilities.cpp

Issue 2950053002: Make Position::BeforeNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-21T17:56:36 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/EditingUtilities.cpp
diff --git a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
index fc32f24646b720e5275e22d26510a1031fb2a0de..cdc1cd2234c757977d05a9fff9c47afca5dcf562 100644
--- a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
+++ b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
@@ -330,7 +330,7 @@ bool IsNodeFullyContained(const EphemeralRange& range, Node& node) {
if (!NodeTraversal::CommonAncestor(*range.StartPosition().AnchorNode(), node))
return false;
- return range.StartPosition() <= Position::BeforeNode(&node) &&
+ return range.StartPosition() <= Position::BeforeNode(node) &&
Position::AfterNode(&node) <= range.EndPosition();
}
@@ -850,7 +850,7 @@ PositionTemplate<Strategy> PreviousPositionOfAlgorithm(
if (offset > 0) {
if (EditingIgnoresContent(*node))
- return PositionTemplate<Strategy>::BeforeNode(node);
+ return PositionTemplate<Strategy>::BeforeNode(*node);
if (Node* child = Strategy::ChildAt(*node, offset - 1))
return PositionTemplate<Strategy>::LastPositionInOrAfterNode(child);
@@ -876,7 +876,7 @@ PositionTemplate<Strategy> PreviousPositionOfAlgorithm(
if (ContainerNode* parent = Strategy::Parent(*node)) {
if (EditingIgnoresContent(*parent))
- return PositionTemplate<Strategy>::BeforeNode(parent);
+ return PositionTemplate<Strategy>::BeforeNode(*parent);
// TODO(yosin) We should use |Strategy::index(Node&)| instead of
// |Node::nodeIndex()|.
return PositionTemplate<Strategy>(parent, node->NodeIndex());
« no previous file with comments | « third_party/WebKit/Source/core/dom/Range.cpp ('k') | third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698