third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp - Issue 2950053002: Make Position::BeforeNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp

Issue 2950053002: Make Position::BeforeNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-21T17:56:36 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp b/third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp

index 6ec955a378747713f053473220bc47b4f43f01bd..4d20e829befcb69a02a9a138b2120e8277434443 100644

--- a/third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/BreakBlockquoteCommand.cpp

@@ -134,7 +134,7 @@ void BreakBlockquoteCommand::DoApply(EditingState* editing_state) {

if (editing_state->IsAborted())

return;

SetEndingSelection(SelectionInDOMTree::Builder()

- .Collapse(Position::BeforeNode(break_element))

+ .Collapse(Position::BeforeNode(*break_element))

.SetIsDirectional(EndingSelection().IsDirectional())

.Build());

RebalanceWhitespace();

@@ -152,7 +152,7 @@ void BreakBlockquoteCommand::DoApply(EditingState* editing_state) {

// need to break the quote.

if (is_last_vis_pos_in_node) {

SetEndingSelection(SelectionInDOMTree::Builder()

- .Collapse(Position::BeforeNode(break_element))

+ .Collapse(Position::BeforeNode(*break_element))

.SetIsDirectional(EndingSelection().IsDirectional())

.Build());

RebalanceWhitespace();

@@ -282,7 +282,7 @@ void BreakBlockquoteCommand::DoApply(EditingState* editing_state) {

// Put the selection right before the break.

SetEndingSelection(SelectionInDOMTree::Builder()

- .Collapse(Position::BeforeNode(break_element))

+ .Collapse(Position::BeforeNode(*break_element))

.SetIsDirectional(EndingSelection().IsDirectional())

.Build());

RebalanceWhitespace();