third_party/WebKit/Source/core/editing/PositionTest.cpp - Issue 2950053002: Make Position::BeforeNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/PositionTest.cpp

Issue 2950053002: Make Position::BeforeNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-21T17:56:36 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp ('k') | third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/PositionTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/PositionTest.cpp b/third_party/WebKit/Source/core/editing/PositionTest.cpp

index f158bca8ff5a648489df1959f5ffcd986a331740..fb9aba8424f2fde5083c241e6510c26aab11e04a 100644

--- a/third_party/WebKit/Source/core/editing/PositionTest.cpp

+++ b/third_party/WebKit/Source/core/editing/PositionTest.cpp

@@ -20,13 +20,13 @@ TEST_F(PositionTest, IsEquivalent) {

EXPECT_TRUE(

Position(sample, 0).IsEquivalent(Position::FirstPositionInNode(sample)));

EXPECT_TRUE(Position(sample, 0).IsEquivalent(

- Position::BeforeNode(sample->firstChild())));

+ Position::BeforeNode(*sample->firstChild())));

EXPECT_TRUE(Position(sample, 1).IsEquivalent(

Position::AfterNode(sample->firstChild())));

EXPECT_TRUE(Position(sample, 1).IsEquivalent(

- Position::BeforeNode(sample->firstChild()->nextSibling())));

+ Position::BeforeNode(*sample->firstChild()->nextSibling())));

EXPECT_TRUE(Position(sample, 2).IsEquivalent(

- Position::BeforeNode(sample->lastChild())));

+ Position::BeforeNode(*sample->lastChild())));

EXPECT_TRUE(Position(sample, 3).IsEquivalent(

Position::AfterNode(sample->lastChild())));

EXPECT_TRUE(

@@ -48,7 +48,7 @@ TEST_F(PositionTest, editingPositionOfWithEditingIgnoresContent) {

SetBodyContent(body_content);

Node* textarea = GetDocument().getElementById("textarea");

- EXPECT_EQ(Position::BeforeNode(textarea),

+ EXPECT_EQ(Position::BeforeNode(*textarea),

Position::EditingPositionOf(textarea, 0));

EXPECT_EQ(Position::AfterNode(textarea),

Position::EditingPositionOf(textarea, 1));

@@ -62,7 +62,7 @@ TEST_F(PositionTest, editingPositionOfWithEditingIgnoresContent) {

textarea->appendChild(child1);

textarea->appendChild(child2);

- EXPECT_EQ(Position::BeforeNode(textarea),

+ EXPECT_EQ(Position::BeforeNode(*textarea),

Position::EditingPositionOf(textarea, 0));

EXPECT_EQ(Position::AfterNode(textarea),

Position::EditingPositionOf(textarea, 1));