Make Position::BeforeNode() to take const Node& instead of Node*

third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/VisibleUnits.h"
 
 #include <ostream>  // NOLINT
 #include "bindings/core/v8/V8BindingForTesting.h"
 #include "core/dom/Text.h"
 #include "core/editing/EditingTestBase.h"
@@ skipping 226 matching lines @@
             CanonicalPositionOf(Position(two, 0)));
   EXPECT_EQ(Position(two->firstChild(), 2),
             CanonicalPositionOf(Position(two, 1)));
 }
 
 // For http://crbug.com/695317
 TEST_F(VisibleUnitsTest, canonicalPositionOfWithInputElement) {
   SetBodyContent("<input>123");
   Element* const input = GetDocument().QuerySelector("input");
 
-  EXPECT_EQ(Position::BeforeNode(input),
+  EXPECT_EQ(Position::BeforeNode(*input),
             CanonicalPositionOf(Position::FirstPositionInNode(
                 GetDocument().documentElement())));
 
-  EXPECT_EQ(PositionInFlatTree::BeforeNode(input),
+  EXPECT_EQ(PositionInFlatTree::BeforeNode(*input),
             CanonicalPositionOf(PositionInFlatTree::FirstPositionInNode(
                 GetDocument().documentElement())));
 }
 
 TEST_F(VisibleUnitsTest, characterBefore) {
   const char* body_content =
       "<p id=host><b id=one>1</b><b id=two>22</b></p><b id=three>333</b>";
   const char* shadow_content =
       "<b id=four>4444</b><content select=#two></content><content "
       "select=#one></content><b id=five>5555</b>";
@@ skipping 1072 matching lines @@
       "<style>p:first-letter {color:red;}</style><p id=sample> (2)45 </p>";
   SetBodyContent(body_content);
 
   Node* sample = GetDocument().getElementById("sample")->firstChild();
 
   EXPECT_EQ(Position(GetDocument().body(), 0),
             MostForwardCaretPosition(
                 Position::FirstPositionInNode(GetDocument().body())));
   EXPECT_EQ(
       Position(sample, 1),
-      MostForwardCaretPosition(Position::BeforeNode(sample->parentNode())));
+      MostForwardCaretPosition(Position::BeforeNode(*sample->parentNode())));
   EXPECT_EQ(Position(sample, 1),
             MostForwardCaretPosition(
                 Position::FirstPositionInNode(sample->parentNode())));
   EXPECT_EQ(Position(sample, 1), MostForwardCaretPosition(Position(sample, 0)));
   EXPECT_EQ(Position(sample, 1), MostForwardCaretPosition(Position(sample, 1)));
   EXPECT_EQ(Position(sample, 2), MostForwardCaretPosition(Position(sample, 2)));
   EXPECT_EQ(Position(sample, 3), MostForwardCaretPosition(Position(sample, 3)));
   EXPECT_EQ(Position(sample, 4), MostForwardCaretPosition(Position(sample, 4)));
   EXPECT_EQ(Position(sample, 5), MostForwardCaretPosition(Position(sample, 5)));
   EXPECT_EQ(Position(sample, 7), MostForwardCaretPosition(Position(sample, 6)));
@@ skipping 543 matching lines @@
   EXPECT_FALSE(rect.IsEmpty());
 }
 
 // Regression test for crbug.com/675429
 TEST_F(VisibleUnitsTest,
        canonicalizationWithCollapsedSpaceAndIsolatedCombiningCharacter) {
   SetBodyContent("<p>  &#x20E3;</p>");  // Leading space is necessary
 
   Node* paragraph = GetDocument().QuerySelector("p");
   Node* text = paragraph->firstChild();
-  Position start = CanonicalPositionOf(Position::BeforeNode(paragraph));
+  Position start = CanonicalPositionOf(Position::BeforeNode(*paragraph));
   EXPECT_EQ(Position(text, 2), start);
 }
 
 TEST_F(VisibleUnitsTest,
        PreviousRootInlineBoxCandidatePositionWithDisplayNone) {
   SetBodyContent(
       "<div contenteditable>"
       "<div id=one>one abc</div>"
       "<div id=two>two <b id=none style=display:none>def</b> ghi</div>"
       "</div>");
   Element* const one = GetDocument().getElementById("one");
   Element* const two = GetDocument().getElementById("two");
   const VisiblePosition& visible_position =
       CreateVisiblePosition(Position::LastPositionInNode(two));
   EXPECT_EQ(Position(one->firstChild(), 7),
             PreviousRootInlineBoxCandidatePosition(
                 two->lastChild(), visible_position, kContentIsEditable));
 }
 
 }  // namespace blink