third_party/WebKit/Source/core/editing/PositionIterator.cpp - Issue 2950053002: Make Position::BeforeNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/PositionIterator.cpp

Issue 2950053002: Make Position::BeforeNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-21T17:56:36 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/PositionIterator.cpp

diff --git a/third_party/WebKit/Source/core/editing/PositionIterator.cpp b/third_party/WebKit/Source/core/editing/PositionIterator.cpp

index 804873f8fdd8af297e54d119d8b84dd7ccb2434a..efcf772ff90497ae149846260ecdff96c62dc7bf 100644

--- a/third_party/WebKit/Source/core/editing/PositionIterator.cpp

+++ b/third_party/WebKit/Source/core/editing/PositionIterator.cpp

@@ -96,7 +96,7 @@ PositionIteratorAlgorithm<Strategy>::DeprecatedComputePosition() const {

// editing

if (EditingIgnoresContent(

*Strategy::Parent(*node_after_position_in_anchor_)))

- return PositionTemplate<Strategy>::BeforeNode(anchor_node_);

+ return PositionTemplate<Strategy>::BeforeNode(*anchor_node_);

return PositionTemplate<Strategy>(

anchor_node_, offsets_in_anchor_node_[depth_to_anchor_node_]);

}