Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp

Issue 2950053002: Make Position::BeforeNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-21T17:56:36 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp b/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
index 88e68409e6e56889712a88e9de3c724ed6fd915d..b7cba20a17e18b963661354e668789f21634b580 100644
--- a/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleUnitsTest.cpp
@@ -244,11 +244,11 @@ TEST_F(VisibleUnitsTest, canonicalPositionOfWithInputElement) {
SetBodyContent("<input>123");
Element* const input = GetDocument().QuerySelector("input");
- EXPECT_EQ(Position::BeforeNode(input),
+ EXPECT_EQ(Position::BeforeNode(*input),
CanonicalPositionOf(Position::FirstPositionInNode(
GetDocument().documentElement())));
- EXPECT_EQ(PositionInFlatTree::BeforeNode(input),
+ EXPECT_EQ(PositionInFlatTree::BeforeNode(*input),
CanonicalPositionOf(PositionInFlatTree::FirstPositionInNode(
GetDocument().documentElement())));
}
@@ -1341,7 +1341,7 @@ TEST_F(VisibleUnitsTest, mostForwardCaretPositionFirstLetter) {
Position::FirstPositionInNode(GetDocument().body())));
EXPECT_EQ(
Position(sample, 1),
- MostForwardCaretPosition(Position::BeforeNode(sample->parentNode())));
+ MostForwardCaretPosition(Position::BeforeNode(*sample->parentNode())));
EXPECT_EQ(Position(sample, 1),
MostForwardCaretPosition(
Position::FirstPositionInNode(sample->parentNode())));
@@ -1905,7 +1905,7 @@ TEST_F(VisibleUnitsTest,
Node* paragraph = GetDocument().QuerySelector("p");
Node* text = paragraph->firstChild();
- Position start = CanonicalPositionOf(Position::BeforeNode(paragraph));
+ Position start = CanonicalPositionOf(Position::BeforeNode(*paragraph));
EXPECT_EQ(Position(text, 2), start);
}

Powered by Google App Engine
This is Rietveld 408576698