third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp - Issue 2950053002: Make Position::BeforeNode() to take const Node& instead of Node*

Unified Diff: third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp

Issue 2950053002: Make Position::BeforeNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-21T17:56:36 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/Source/core/editing/PositionIterator.cpp ('k') | third_party/WebKit/Source/core/editing/PositionTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp b/third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp

index 041957a5594cb802ec4f2630016b20a5827e9a9e..fe63644301e54415092b7d5de2267bb756e686ce 100644

--- a/third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp

+++ b/third_party/WebKit/Source/core/editing/PositionIteratorTest.cpp

@@ -25,7 +25,7 @@ TEST_F(PositionIteratorTest, decrementWithInputElement) {

dom_iterator.Decrement();

EXPECT_EQ(Position::AfterNode(input), dom_iterator.ComputePosition());

dom_iterator.Decrement();

- EXPECT_EQ(Position::BeforeNode(input), dom_iterator.ComputePosition());

+ EXPECT_EQ(Position::BeforeNode(*input), dom_iterator.ComputePosition());

dom_iterator.Decrement();

EXPECT_EQ(Position(GetDocument().body(), 1), dom_iterator.ComputePosition());

dom_iterator.Decrement();

@@ -40,7 +40,7 @@ TEST_F(PositionIteratorTest, decrementWithInputElement) {

EXPECT_EQ(PositionInFlatTree::AfterNode(input),

flat_iterator.ComputePosition());

flat_iterator.Decrement();

- EXPECT_EQ(PositionInFlatTree::BeforeNode(input),

+ EXPECT_EQ(PositionInFlatTree::BeforeNode(*input),

flat_iterator.ComputePosition());

flat_iterator.Decrement();

EXPECT_EQ(PositionInFlatTree(GetDocument().body(), 1),

@@ -66,7 +66,7 @@ TEST_F(PositionIteratorTest, decrementWithSelectElement) {

<< "This is redundant result, we should not have. see "

"http://crbug.com/697283";

dom_iterator.Decrement();

- EXPECT_EQ(Position::BeforeNode(select), dom_iterator.ComputePosition());

+ EXPECT_EQ(Position::BeforeNode(*select), dom_iterator.ComputePosition());

dom_iterator.Decrement();

EXPECT_EQ(Position(GetDocument().body(), 1), dom_iterator.ComputePosition());

dom_iterator.Decrement();

@@ -86,7 +86,7 @@ TEST_F(PositionIteratorTest, decrementWithSelectElement) {

<< "This is redundant result, we should not have. see "

"http://crbug.com/697283";

flat_iterator.Decrement();

- EXPECT_EQ(PositionInFlatTree::BeforeNode(select),

+ EXPECT_EQ(PositionInFlatTree::BeforeNode(*select),

flat_iterator.ComputePosition());

flat_iterator.Decrement();

EXPECT_EQ(PositionInFlatTree(GetDocument().body(), 1),

@@ -109,7 +109,7 @@ TEST_F(PositionIteratorTest, decrementWithTextAreaElement) {

dom_iterator.Decrement();

EXPECT_EQ(Position::AfterNode(textarea), dom_iterator.ComputePosition());

dom_iterator.Decrement();

- EXPECT_EQ(Position::BeforeNode(textarea), dom_iterator.ComputePosition());

+ EXPECT_EQ(Position::BeforeNode(*textarea), dom_iterator.ComputePosition());

dom_iterator.Decrement();

EXPECT_EQ(Position(GetDocument().body(), 1), dom_iterator.ComputePosition());

dom_iterator.Decrement();

@@ -124,7 +124,7 @@ TEST_F(PositionIteratorTest, decrementWithTextAreaElement) {

EXPECT_EQ(PositionInFlatTree::AfterNode(textarea),

flat_iterator.ComputePosition());

flat_iterator.Decrement();

- EXPECT_EQ(PositionInFlatTree::BeforeNode(textarea),

+ EXPECT_EQ(PositionInFlatTree::BeforeNode(*textarea),

flat_iterator.ComputePosition());

flat_iterator.Decrement();

EXPECT_EQ(PositionInFlatTree(GetDocument().body(), 1),

@@ -144,7 +144,7 @@ TEST_F(PositionIteratorTest, incrementWithInputElement) {

Position::FirstPositionInNode(GetDocument().body()));

EXPECT_EQ(Position(GetDocument().body(), 0), dom_iterator.ComputePosition());

dom_iterator.Increment();

- EXPECT_EQ(Position::BeforeNode(input), dom_iterator.ComputePosition());

+ EXPECT_EQ(Position::BeforeNode(*input), dom_iterator.ComputePosition());

dom_iterator.Increment();

EXPECT_EQ(Position::AfterNode(input), dom_iterator.ComputePosition());

dom_iterator.Increment();

@@ -158,7 +158,7 @@ TEST_F(PositionIteratorTest, incrementWithInputElement) {

EXPECT_EQ(PositionInFlatTree(GetDocument().body(), 0),

flat_iterator.ComputePosition());

flat_iterator.Increment();

- EXPECT_EQ(PositionInFlatTree::BeforeNode(input),

+ EXPECT_EQ(PositionInFlatTree::BeforeNode(*input),

flat_iterator.ComputePosition());

flat_iterator.Increment();

EXPECT_EQ(PositionInFlatTree::AfterNode(input),

@@ -180,7 +180,7 @@ TEST_F(PositionIteratorTest, incrementWithSelectElement) {

Position::FirstPositionInNode(GetDocument().body()));

EXPECT_EQ(Position(GetDocument().body(), 0), dom_iterator.ComputePosition());

dom_iterator.Increment();

- EXPECT_EQ(Position::BeforeNode(select), dom_iterator.ComputePosition());

+ EXPECT_EQ(Position::BeforeNode(*select), dom_iterator.ComputePosition());

dom_iterator.Increment();

EXPECT_EQ(Position::AfterNode(select), dom_iterator.ComputePosition());

dom_iterator.Increment();

@@ -198,7 +198,7 @@ TEST_F(PositionIteratorTest, incrementWithSelectElement) {

EXPECT_EQ(PositionInFlatTree(GetDocument().body(), 0),

flat_iterator.ComputePosition());

flat_iterator.Increment();

- EXPECT_EQ(PositionInFlatTree::BeforeNode(select),

+ EXPECT_EQ(PositionInFlatTree::BeforeNode(*select),

flat_iterator.ComputePosition());

flat_iterator.Increment();

EXPECT_EQ(PositionInFlatTree::AfterNode(select),

@@ -226,7 +226,7 @@ TEST_F(PositionIteratorTest, incrementWithTextAreaElement) {

Position::FirstPositionInNode(GetDocument().body()));

EXPECT_EQ(Position(GetDocument().body(), 0), dom_iterator.ComputePosition());

dom_iterator.Increment();

- EXPECT_EQ(Position::BeforeNode(textarea), dom_iterator.ComputePosition());

+ EXPECT_EQ(Position::BeforeNode(*textarea), dom_iterator.ComputePosition());

dom_iterator.Increment();

EXPECT_EQ(Position::AfterNode(textarea), dom_iterator.ComputePosition());

dom_iterator.Increment();

@@ -241,7 +241,7 @@ TEST_F(PositionIteratorTest, incrementWithTextAreaElement) {

flat_iterator.ComputePosition());

// TODO(yosin): We should not traverse inside TEXTAREA

flat_iterator.Increment();

- EXPECT_EQ(PositionInFlatTree::BeforeNode(textarea),

+ EXPECT_EQ(PositionInFlatTree::BeforeNode(*textarea),

flat_iterator.ComputePosition());

flat_iterator.Increment();

EXPECT_EQ(PositionInFlatTree::AfterNode(textarea),