Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp

Issue 2950053002: Make Position::BeforeNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-21T17:56:36 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp
diff --git a/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp b/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp
index 0cedabce3c5eeb85cba5a6440d28d466c05b0b83..d9a3c0f0b79cbae25b90672c261d20156191b74e 100644
--- a/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp
+++ b/third_party/WebKit/Source/core/editing/VisibleUnitsLine.cpp
@@ -216,7 +216,7 @@ PositionWithAffinityTemplate<Strategy> StartPositionForLine(
start_node->IsTextNode()
? PositionTemplate<Strategy>(ToText(start_node),
ToInlineTextBox(start_box)->Start())
- : PositionTemplate<Strategy>::BeforeNode(start_node));
+ : PositionTemplate<Strategy>::BeforeNode(*start_node));
}
template <typename Strategy>
@@ -301,7 +301,7 @@ Position PreviousRootInlineBoxCandidatePosition(
const Position& candidate =
isHTMLBRElement(*runner)
- ? Position::BeforeNode(runner)
+ ? Position::BeforeNode(*runner)
: Position::EditingPositionOf(runner, CaretMaxOffset(runner));
if (IsVisuallyEquivalentCandidate(candidate))
return candidate;
@@ -429,7 +429,7 @@ static VisiblePositionTemplate<Strategy> EndPositionForLine(
if (isHTMLBRElement(*end_node)) {
return CreateVisiblePosition(
- PositionTemplate<Strategy>::BeforeNode(end_node),
+ PositionTemplate<Strategy>::BeforeNode(*end_node),
VP_UPSTREAM_IF_POSSIBLE);
}
if (end_box->IsInlineTextBox() && end_node->IsTextNode()) {

Powered by Google App Engine
This is Rietveld 408576698