third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp - Issue 2950053002: Make Position::BeforeNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

Issue 2950053002: Make Position::BeforeNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-21T17:56:36 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

index 801ba8f69807831a5ac0759ddcca72ce72deadb0..e89026a1a1419a939bc7400641f15014fa7fe1ba 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

@@ -576,7 +576,7 @@ void InsertListCommand::ListifyParagraph(const VisiblePosition& original_start,

if (previous_list)

AppendNode(list_item_element, previous_list, editing_state);

else

- InsertNodeAt(list_item_element, Position::BeforeNode(next_list),

+ InsertNodeAt(list_item_element, Position::BeforeNode(*next_list),

editing_state);

if (editing_state->IsAborted())

return;

@@ -605,7 +605,7 @@ void InsertListCommand::ListifyParagraph(const VisiblePosition& original_start,

InsertBlockPlaceholder(start_pos, editing_state);

if (editing_state->IsAborted())

return;

- start_pos = Position::BeforeNode(placeholder);

+ start_pos = Position::BeforeNode(*placeholder);

}

GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheets();