Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: third_party/WebKit/Source/core/editing/SelectionController.cpp

Issue 2950053002: Make Position::BeforeNode() to take const Node& instead of Node* (Closed)
Patch Set: 2017-06-21T17:56:36 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/SelectionController.cpp
diff --git a/third_party/WebKit/Source/core/editing/SelectionController.cpp b/third_party/WebKit/Source/core/editing/SelectionController.cpp
index 64774b9ae378fde81561d31b2c985535acf4cecb..e04ac10fca2b4828dfdd72ee0a1360c5c490d415 100644
--- a/third_party/WebKit/Source/core/editing/SelectionController.cpp
+++ b/third_party/WebKit/Source/core/editing/SelectionController.cpp
@@ -89,7 +89,7 @@ VisibleSelectionInFlatTree ExpandSelectionToRespectUserSelectAll(
return CreateVisibleSelection(
SelectionInFlatTree::Builder(selection.AsSelection())
.Collapse(MostBackwardCaretPosition(
- PositionInFlatTree::BeforeNode(root_user_select_all),
+ PositionInFlatTree::BeforeNode(*root_user_select_all),
kCanCrossEditingBoundary))
.Extend(MostForwardCaretPosition(
PositionInFlatTree::AfterNode(root_user_select_all),
@@ -316,7 +316,7 @@ static SelectionInFlatTree ApplySelectAll(
root_user_select_all_for_target) {
return SelectionInFlatTree::Builder()
.SetBaseAndExtent(PositionInFlatTree::BeforeNode(
- root_user_select_all_for_mouse_press_node),
+ *root_user_select_all_for_mouse_press_node),
PositionInFlatTree::AfterNode(
root_user_select_all_for_mouse_press_node))
.Build();
@@ -338,7 +338,7 @@ static SelectionInFlatTree ApplySelectAll(
if (TargetPositionIsBeforeDragStartPosition(
mouse_press_node, drag_start_point, target, hit_test_point)) {
builder.Extend(
- PositionInFlatTree::BeforeNode(root_user_select_all_for_target));
+ PositionInFlatTree::BeforeNode(*root_user_select_all_for_target));
return builder.Build();
}

Powered by Google App Engine
This is Rietveld 408576698