Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2689053002: MD Settings: label and describe a bunch of subpage/open-in-new buttons (Closed)

Created:
3 years, 10 months ago by Dan Beam
Modified:
3 years, 10 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: label and describe a bunch of subpage/open-in-new buttons R=hcarmona@chromium.org BUG=686330, 686327, 686309 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2689053002 Cr-Commit-Position: refs/heads/master@{#450038} Committed: https://chromium.googlesource.com/chromium/src/+/610b2e126ebb150af06f8400c73e6341c32cddb7

Patch Set 1 #

Patch Set 2 : siteSetings #

Patch Set 3 : asdf #

Patch Set 4 : fix #

Total comments: 2

Patch Set 5 : downloadSize -> downloadsSize #

Unified diffs Side-by-side diffs Delta from patch set Stats (+326 lines, -158 lines) Patch
M chrome/browser/resources/settings/a11y_page/a11y_page.html View 2 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/a11y_page/manage_a11y_page.html View 5 chunks +32 lines, -11 lines 0 comments Download
M chrome/browser/resources/settings/about_page/about_page.html View 1 chunk +8 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/appearance_page/appearance_page.html View 3 chunks +18 lines, -8 lines 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html View 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/date_time_page/date_time_page.html View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/device_page/device_page.html View 1 chunk +11 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/device_page/display.html View 2 chunks +14 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/device_page/keyboard.html View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/device_page/storage.html View 1 2 3 4 5 chunks +15 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/device_page/stylus.html View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_page.html View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_summary_item.html View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html View 2 chunks +14 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/people_page/lock_screen.html View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/people_page/people_page.html View 1 2 3 6 chunks +30 lines, -15 lines 0 comments Download
M chrome/browser/resources/settings/people_page/sync_page.html View 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/cloud_printers.html View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/printing_page.html View 2 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 3 chunks +24 lines, -11 lines 0 comments Download
M chrome/browser/resources/settings/reset_page/reset_page.html View 2 chunks +14 lines, -6 lines 0 comments Download
M chrome/browser/resources/settings/search_page/search_page.html View 2 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_data.html View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_list.html View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/site_settings_page/site_settings_page.html View 1 15 chunks +65 lines, -34 lines 0 comments Download

Messages

Total messages: 26 (21 generated)
Dan Beam
3 years, 10 months ago (2017-02-11 22:56:51 UTC) #2
hcarmona
LGTM, w/ small change https://codereview.chromium.org/2689053002/diff/60001/chrome/browser/resources/settings/device_page/storage.html File chrome/browser/resources/settings/device_page/storage.html (right): https://codereview.chromium.org/2689053002/diff/60001/chrome/browser/resources/settings/device_page/storage.html#newcode188 chrome/browser/resources/settings/device_page/storage.html:188: aria-describedby="downloadSize"></button> aria-describedby="downloadsSize"
3 years, 10 months ago (2017-02-13 17:53:54 UTC) #15
Dan Beam
https://codereview.chromium.org/2689053002/diff/60001/chrome/browser/resources/settings/device_page/storage.html File chrome/browser/resources/settings/device_page/storage.html (right): https://codereview.chromium.org/2689053002/diff/60001/chrome/browser/resources/settings/device_page/storage.html#newcode188 chrome/browser/resources/settings/device_page/storage.html:188: aria-describedby="downloadSize"></button> On 2017/02/13 17:53:54, hcarmona wrote: > aria-describedby="downloadsSize" Done.
3 years, 10 months ago (2017-02-13 17:56:18 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689053002/80001
3 years, 10 months ago (2017-02-13 19:12:14 UTC) #23
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 19:21:53 UTC) #26
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/610b2e126ebb150af06f8400c73e...

Powered by Google App Engine
This is Rietveld 408576698