Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: chrome/browser/resources/settings/reset_page/reset_page.html

Issue 2689053002: MD Settings: label and describe a bunch of subpage/open-in-new buttons (Closed)
Patch Set: downloadSize -> downloadsSize Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/reset_page/reset_page.html
diff --git a/chrome/browser/resources/settings/reset_page/reset_page.html b/chrome/browser/resources/settings/reset_page/reset_page.html
index d2420594d93313a5371e4a051a182e5a23ecdb69..ce27e28e009fbe5c46148be394c9de0ae44e1b26 100644
--- a/chrome/browser/resources/settings/reset_page/reset_page.html
+++ b/chrome/browser/resources/settings/reset_page/reset_page.html
@@ -16,10 +16,14 @@
<div class="settings-box first two-line" id="resetProfile"
on-tap="onShowResetProfileDialog_" actionable>
<div class="start">
- <div>$i18n{resetPageTitle}</div>
- <div class="secondary">$i18n{resetPageDescription}</div>
+ $i18n{resetPageTitle}
+ <div class="secondary" id="resetProfileSecondary">
+ $i18n{resetPageDescription}
+ </div>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{resetPageTitle}"
+ aria-describedby="resetProfileSecondary"></button>
</div>
<template is="dom-if" if="[[showResetProfileDialog_]]" restamp>
<settings-reset-profile-dialog on-close="onResetProfileDialogClose_">
@@ -29,10 +33,14 @@
<div class="settings-box two-line" id="powerwash" actionable
on-tap="onShowPowerwashDialog_" hidden="[[!allowPowerwash_]]">
<div class="start">
- <div>$i18n{powerwashTitle}</div>
- <div class="secondary">$i18n{powerwashDescription}</div>
+ $i18n{powerwashTitle}
+ <div class="secondary" id="powerwashSecondary">
+ $i18n{powerwashDescription}
+ </div>
</div>
- <button class="subpage-arrow" is="paper-icon-button-light"></button>
+ <button class="subpage-arrow" is="paper-icon-button-light"
+ aria-label="$i18n{powerwashTitle}"
+ aria-describedby="powerwashSecondary"></button>
</div>
<template is="dom-if" if="[[showPowerwashDialog_]]" restamp>
<settings-powerwash-dialog on-close="onPowerwashDialogClose_">

Powered by Google App Engine
This is Rietveld 408576698