chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html - Issue 2689053002: MD Settings: label and describe a bunch of subpage/open-in-new buttons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html

Issue 2689053002: MD Settings: label and describe a bunch of subpage/open-in-new buttons (Closed)

Patch Set: downloadSize -> downloadsSize Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/about_page/about_page.html ('k') | chrome/browser/resources/settings/appearance_page/appearance_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html

diff --git a/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html b/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html

index 8ee3bd836a76d79e87a854b3b546e9a30bb53e04..782feff83453ef9e5614e0987756d64a7ddada4f 100644

--- a/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html

+++ b/chrome/browser/resources/settings/appearance_page/appearance_fonts_page.html

@@ -114,12 +114,14 @@

<div class="settings-box two-line" id="advancedButton"

on-tap="openAdvancedExtension_" actionable>

- <div>$i18n{advancedFontSettings}</div>

+ $i18n{advancedFontSettings}

[[advancedExtensionSublabel_]]

</div>

- <button class="icon-external" is="paper-icon-button-light"></button>

+ <button class="icon-external" is="paper-icon-button-light"

+ aria-label="$i18n{advancedFontSettings}"

+ aria-describedby="advancedButtonSublabel"></button>

</div>

</template>