chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html - Issue 2689053002: MD Settings: label and describe a bunch of subpage/open-in-new buttons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html

Issue 2689053002: MD Settings: label and describe a bunch of subpage/open-in-new buttons (Closed)

Patch Set: downloadSize -> downloadsSize Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/internet_page/network_summary_item.html ('k') | chrome/browser/resources/settings/people_page/lock_screen.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html

index b71ed1d6a90548fff842b9520b8c746625274549..f6e1e37be1c9e0ae02b9a0af8e9b2fdf369475b0 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html

@@ -23,10 +23,14 @@

id="autofillManagerButton"

actionable$="[[prefs.autofill.enabled.value]]">

- <div>$i18n{autofill}</div>

- <div class="secondary">$i18n{autofillDetail}</div>

+ $i18n{autofill}

+ <div class="secondary" id="autofillSecondary">

+ $i18n{autofillDetail}

+ </div>

</div>

- <button class="subpage-arrow" is="paper-icon-button-light"></button>

+ <button class="subpage-arrow" is="paper-icon-button-light"

+ aria-label="$i18n{autofill}"

+ aria-describedby="autofillSecondary"></button>

</div>

<paper-toggle-button id="autofillToggle"

@@ -39,10 +43,14 @@

id="passwordManagerButton"

actionable$="[[prefs.profile.password_manager_enabled.value]]">

- <div>$i18n{passwords}</div>

- <div class="secondary">$i18n{passwordsDetail}</div>

+ $i18n{passwords}

+ <div class="secondary" id="passwordsSecondary">

+ $i18n{passwordsDetail}

+ </div>

</div>

- <button class="subpage-arrow" is="paper-icon-button-light"></button>

+ <button class="subpage-arrow" is="paper-icon-button-light"

+ aria-label="$i18n{passwords}"

+ aria-describedby="passwordsSecondary"></button>

</div>

<paper-toggle-button id="passwordToggle"